** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** - Page 991 - Computer Technical Help

Two Plus Two Forums Other Topics Computer and Technical Help

** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD **

Post Reply Subscribe

...

Page 991 of 1603

First

491 791 891 941 971 981 986 987 988 989 990 991 992 993 994 995 996 1001 1011 1041 1091 1191 1491

Last

Page 991 of 1603

First

491 791 891 941 971 981 986 987 988 989 990 991 992 993 994 995 996 1001 1011 1041 1091 1191 1491

Last

08-17-2016 , 05:54 AM

#24751

clowntable

Carpal \'Tunnel

Join Date: Jun 2006 Posts: 45,557

Quote:

Originally Posted by Grue

serious question, what is the point of code review if this is the kind of stuff you would pass?

You can discuss all the points raised ITT and then have him/her commit the better code. But upon seeing that piece of code my reaction wouldn't be "ZOMG lol haha look at all the little fails" but rather "that's a pretty good start, let's work on it a bit and we have a solid new dev".
I got the feeling the initial post was venting/frustration if I misread that I'm sorry. My initial reaction would be closer to "ok this is solid stuff we can work with".

Quote

$25m Guaranteed WPM on CoinPoker

Join the action now

Daily Rewards • Splash Pots • CoinRaces

08-17-2016 , 06:06 AM

#24752

clowntable

Carpal \'Tunnel

Join Date: Jun 2006 Posts: 45,557

I feel like I could make a case for all answers on the first question if I am the event-handler. I guess phone call is supposed to be the correct answer?

In the day and age of the instant answer expecting cell phone crowd I sometimes even feel like IM and mail are getting closer and closer (and many people essentially use Twitter as read-all IM)

Quote

08-17-2016 , 06:29 AM

#24753

SiQ

Carpal \'Tunnel

Join Date: Jan 2008 Posts: 7,248

First time seeing this. Laughed too much.

Quote

08-17-2016 , 12:02 PM

#24754

Grue

Pooh-Bah

Join Date: Mar 2004 Posts: 5,667

Quote:

Originally Posted by clowntable

well right I mean thats what I told the guy and we fixed it just seemed like people were saying this is acceptable production code which it obvious isn't at least to me.

Quote

08-17-2016 , 05:28 PM

#24755

just_grindin

Pooh-Bah

Join Date: Dec 2007 Posts: 5,263

Humble Bundle is running a Joy of Coding bundle. Anyone read any of the books and recommend? $15 seems cheap to get access to all of those books even if they are so so.

Sent from my SM-G900R4 using Tapatalk

Quote

08-17-2016 , 05:39 PM

#24756

RustyBrooks

Carpal \'Tunnel

Join Date: Feb 2006 Posts: 24,646

That video is pretty good as far as standup programming comedy goes

Quote

08-17-2016 , 08:56 PM

#24757

Grue

Pooh-Bah

Join Date: Mar 2004 Posts: 5,667

does anyone use the airbnb javascript style guide extensively, for eslint or not? If so I'd like to hear opinions on their settings. In particular a few of them seem god awful meaning:

http://eslint.org/docs/rules/comma-dangle
valid:

Code:

var foo = {
    bar: "baz",
}

invalid:

Code:

var foo = {
    bar: "baz"
}

I mean **** off. And other things like requiring any non fat arrow functions to be named? Like I'll use "function" for anonymous functions inside of say jquery because it does "this" the old way, what the **** would I call it? I'm confused.

Quote

08-17-2016 , 09:04 PM

#24758

RustyBrooks

Carpal \'Tunnel

Join Date: Feb 2006 Posts: 24,646

As someone who's spent a lot of time with python I really prefer the dangling commas and add them everywhere. I don't think I'd require them, though. The main use for them is that adding another entry, or moving any existing entry, is just a cut, paste, without having to add a comma. Once you're used to it you do kinda curse anyone who doesn't dangle their commas.

Quote

08-17-2016 , 10:06 PM

#24759

Craggoo

banned

Join Date: Sep 2006 Posts: 12,645

Quote:

Originally Posted by RustyBrooks

I try to do anything to discourage cut/paste. It encourages laziness which means cut/paste huge chunks of code where what you want is only a few lines out of the bunch. Encouraging cut/paste also seems to reinforce the attitude of "hey it works over there so it'll probably work here" which isn't necessarily true.

Quote

08-17-2016 , 10:07 PM

#24760

RustyBrooks

Carpal \'Tunnel

Join Date: Feb 2006 Posts: 24,646

By "facilitate cut and paste" I mean "move the 5th line of a dict to the 2nd one", i.e. tidying up.

Quote

08-17-2016 , 10:47 PM

#24761

iversonian

Carpal \'Tunnel

Join Date: Sep 2003 Posts: 21,447

+1 to dangling commas. kinda surprised to learn there are people who hate them tbh.

Quote

08-18-2016 , 12:07 AM

#24762

_dave_

_Pooh_Bah_

Join Date: Feb 2005 Posts: 13,154

idk I look at these dangling commas and read "syntax error".

Quote

08-18-2016 , 12:50 AM

#24763

suzzer99

Save the Cheerleader, Save the World

Join Date: Nov 2005 Posts: 101,163

Quote:

Originally Posted by Grue

Code:

var foo = {
    bar: "baz",
}

invalid:

Code:

var foo = {
    bar: "baz"
}

Just got with google and stop trying to be hipster

**** AirBnb. Google Maps blows away their entire website in terms of innovation.

Quote

08-18-2016 , 12:54 AM

#24764

suzzer99

Save the Cheerleader, Save the World

Join Date: Nov 2005 Posts: 101,163

Quote:

Originally Posted by Craggoo

wat

Quote

08-18-2016 , 12:55 AM

#24765

suzzer99

Save the Cheerleader, Save the World

Join Date: Nov 2005 Posts: 101,163

Quote:

Originally Posted by _dave_

idk I look at these dangling commas and read "syntax error".

You and the JSON guy.

Quote

08-18-2016 , 08:42 AM

#24766

Grue

Pooh-Bah

Join Date: Mar 2004 Posts: 5,667

Quote:

Originally Posted by suzzer99

Just got with google and stop trying to be hipster

**** AirBnb. Google Maps blows away their entire website in terms of innovation.

yeah think I'm going to look elsewhere. My .eslintrc is literally "extend airbnb, 15 lines of disabling their bull****".

Quote

08-18-2016 , 02:11 PM

#24767

suzzer99

Save the Cheerleader, Save the World

Join Date: Nov 2005 Posts: 101,163

*go with google https://google.github.io/styleguide/javascriptguide.xml

I agree with almost all of this except else on the same line as closing braces.

Code:

if (something) {
  // ...
} else {
  // ...
}

It makes the code so much more bunched up and harder to read imo:

Code:

if (something) {
  const foo = 'foo' + someOtherVar;
  const bar = (isBar) ? 'yes' : 'no';
  doSomething(foo, bar);
} else {
  const turd = 'something' + someOtherVar;
  const blarg = (isBlarg) ? 'yes' : 'no';
  doSomethingElse(turd, blarg);
}

Gross. (yes the code is dumb, just imagine other code)

So you pretty much have to wrap the else with blank lines, which means that to match you have to add blank lines at the top of block 1 and bottom of block 2:

Code:

if (something) {

  const foo = 'foo' + someOtherVar;
  const bar = (isBar) ? 'yes' : 'no';
  doSomething(foo, bar);

} else {

  const turd = 'something' + someOtherVar;
  const blarg = (isBlarg) ? 'yes' : 'no';
  doSomethingElse(turd, blarg);

}

Also gross. When you could just do this and save 3 lines of vertical space.

Code:

if (something) {
  const foo = 'foo' + someOtherVar;
  const bar = (isBar) ? 'yes' : 'no';
  doSomething(foo, bar);
} 
else {
  const turd = 'something' + someOtherVar;
  const blarg = (isBlarg) ? 'yes' : 'no';
  doSomethingElse(turd, blarg);
}

Last edited by suzzer99; 08-18-2016 at 02:23 PM.

Quote

08-18-2016 , 04:14 PM

#24768

SiQ

Carpal \'Tunnel

Join Date: Jan 2008 Posts: 7,248

I think I lean more towards your last example, but the OTB example looks a lot less bad in an editor

Quote

08-18-2016 , 05:46 PM

#24769

RustyBrooks

Carpal \'Tunnel

Join Date: Feb 2006 Posts: 24,646

What? I like the first example and hate your last one. This is the problem with these standards imo, it's not like there's an objectively best/correct one.

Quote

08-18-2016 , 06:02 PM

#24770

suzzer99

Save the Cheerleader, Save the World

Join Date: Nov 2005 Posts: 101,163

Do you also like ketchup on hot dogs? Maybe we can find a correlation.

Quote

08-18-2016 , 06:18 PM

#24771

RustyBrooks

Carpal \'Tunnel

Join Date: Feb 2006 Posts: 24,646

I've seen so much weird stuff. People who like a space between the function name and args, like

Code:

void myfun (int arg1, char arg2)

People who like the args on the next line

Code:

void myfun 
(int arg1, char arg2)

or even spread out like

Code:

void myfun 
(
    int arg1, 
    char arg2
)

I'm working on a python codebase where the developer never put spaces after commas, just

Code:

mylist = [1,2,3,4,5]

Every one of these people thinks they're doing it right

Quote

08-18-2016 , 06:34 PM

#24772

SiQ

Carpal \'Tunnel

Join Date: Jan 2008 Posts: 7,248

I like the OTB style in most cases. But there are some occasions where for whatever reason I just intuitively feel like it looks wrong (i think it might be stuff like when an else if expression is long and the line above it also uses parens). So for the sake of being consistent I put them on the next line.

and ketchup belongs on hotdogs you anustart

Quote

08-18-2016 , 09:23 PM

#24773

ChrisV

Carpal \'Tunnel

Join Date: Jul 2004 Posts: 40,336

Any of those else styles is fine imo. What is not fine is this:

Code:

}
else
{

Quote

08-18-2016 , 09:26 PM

#24774

ChrisV

Carpal \'Tunnel

Join Date: Jul 2004 Posts: 40,336

Rusty, I've occasionally done the one argument per line thing when the function has eleventeen million arguments and the arguments list would otherwise be unreadable. Usually my solution to that would be a parameters object, the problem arises when I need to override an existing function.

Quote

08-18-2016 , 09:35 PM

#24775

RustyBrooks

Carpal \'Tunnel

Join Date: Feb 2006 Posts: 24,646

Quote:

Originally Posted by ChrisV

I have a bunch of barely consistent rules I use. When there are a lot of parameters, I am willing to devote a lot of vertical space to it, sure. But when there's 2 arguments and you just made the function definition 5 lines tall? No. **** you. Also, if most of those arguments aren't optional, your function probably sucks.