Open Side Menu Go to the Top

02-06-2012 , 11:15 PM
Quote:
Originally Posted by goofyballer
I'm going to be having an awkward conversation tomorrow. One of our other engineers basically reformatted half of a file that I own in his own coding style - we don't have super stringent standards about stuff like spacing/which line braces go on/etc., the general rule is just "stay consistent within a file." So I have to kind of WTF when he makes a functional change to only one line in a function and yet reformats the whole thing in his preferred spacing/brace format. Really?
I've done that a few times, entirely by accident. I'll hit my "reformat file" key in the IDE without noticing, and the whole file changes. Sometimes I don't even realize it until after I commit (if at all). Best argument I can think of for a standardized style
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD **
$25m Guaranteed WPM on CoinPoker
Join the action now
Daily Rewards • Splash Pots • CoinRaces
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD **
02-06-2012 , 11:16 PM
is he cool enough to have an ide that auto-formatted the file simply because he touched it? i have a colleague who is configured this way (though we have a documented coding style and his changes are generally pretty innocuous: delete trailing whitespace, wrap at 100 chars, etc.)
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
02-06-2012 , 11:26 PM
Quote:
Originally Posted by goofyballer
I'm going to be having an awkward conversation tomorrow. One of our other engineers basically reformatted half of a file that I own in his own coding style - we don't have super stringent standards about stuff like spacing/which line braces go on/etc., the general rule is just "stay consistent within a file." So I have to kind of WTF when he makes a functional change to one line in a function and yet reformats the whole thing in his preferred spacing/brace format and renames all the variables. Really?
Code is like a cat, nobody owns it. There might be a section where you are the primary on it, but that is saying something different. Not saying he was right to do that, but the team really should have a consistent standard when it comes to formatting.

Quote:
Originally Posted by Zurvan
I've done that a few times, entirely by accident. I'll hit my "reformat file" key in the IDE without noticing, and the whole file changes. Sometimes I don't even realize it until after I commit (if at all). Best argument I can think of for a standardized style
You don't look at a diff before you commit?
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
02-06-2012 , 11:44 PM
Quote:
Originally Posted by TheIrishThug
Code is like a cat, nobody owns it.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
02-07-2012 , 12:07 AM
Anyone experienced with PHPBB? We currently have an ASP.net website and Classic ASP forum. Our forum to be honest has been letting us down recently, half the problem with it is my fault from not really knowing what I was doing when I first integrated it months ago, and the other half is the forum itself. Some problems have been fixed, but it's so heavily ingrained in our website it would take a while to update, and I'd rather invest that time in installing a more stable forum. It's a mammoth job but our current forum gets a lot of complaints (daily) and is definitely holding back people from posting or using it regularly.

As far as other forums go PHPBB3 seems like the only one that supports MS-SQL server. There's no ASP.net forums that are any good last time I reviewed them. I've got PHPBB3 all set up and installed on my dev server ready to write the scripts to move all the data over.

However, on our site the forum is central to the user authentication. We have 1 login for the entire site which people love and is a lot better/simpler for users than having to setup mulitple accounts or keep logging in again.

It looks tricky to get IIS to share session data between PHP and ASP.net. PHPBB uses sessions to authenticate users and currently our site just uses cookies. Our current forum had an option to disable sessions and authenticate with cookies only which suited us best as it works across the entire site without any problems at all, all languages have access to those cookies.

Does anyone know in PHPBB3 if it's possible to disable sessions and use cookie authentication? Also if anyone has any suggestions would be appreciated, I really want to get it right this time as the current forum really just soaks up a lot of my time dealing with problems on it. If anyone has other better suggestions I'd love to hear them. It's a frustrating task for me as the site originally used PHPBB3, now I have to move it back! The original decision was made because I am experienced in Classic ASP for modifications, and it solved authentication problems by not relying on session variables. I'm deeply regretting it now because this has been a massive time soak and huge PITA (moving users from one authentication system to another is just a huge huge headache, moving the forum structure + posts is pretty easyish but time consuming), which is why I want to absolutely make sure I do everything right this time.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
02-07-2012 , 12:18 AM
Quote:
Originally Posted by tyler_cracker
is he cool enough to have an ide that auto-formatted the file simply because he touched it? i have a colleague who is configured this way (though we have a documented coding style and his changes are generally pretty innocuous: delete trailing whitespace, wrap at 100 chars, etc.)
Only to a certain degree - I often see trailing whitespace removed automatically when diffing his changes, but that's the extent of any reformatting.

Quote:
Originally Posted by TheIrishThug
Code is like a cat, nobody owns it.
A+
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
02-07-2012 , 01:45 AM
02-07-2012 , 01:53 AM
cool article about java etc. Will make sure i pay extra special attention in haskell and a lil bit less in java .

na but thx, kind of makes you realise taking the easy option for sake of being lazy is extremely bad and will impact your life. Ta
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
02-07-2012 , 05:10 AM
The above is the underlying reason why you *should* have a company standard for code style. IDEs such as eclipse allow you to import a style template which makes this easier.

Nothing sucks more than diff'ing a file that some kind soul decided to do a reformat of.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
02-07-2012 , 07:23 AM
Quote:
Originally Posted by TheIrishThug
You don't look at a diff before you commit?
Depending on what I've done to it, no

I spend much of my programming time either working on single dev projects, or making minor one-line changes to other people's stuff that I usually don't bother. Don't say it, I know.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
02-07-2012 , 11:55 AM
zurvan,

if i had a nickel for every "one-line change" that resulted in a huge, broken-ass commit (which the developer would have noticed with even a cursory diff review), i would not be in the job market right now.

Last edited by tyler_cracker; 02-07-2012 at 11:55 AM. Reason: I SAID IT
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
02-07-2012 , 12:28 PM
Quote:
Originally Posted by goofyballer
I'm going to be having an awkward conversation tomorrow. One of our other engineers basically reformatted half of a file that I own in his own coding style - we don't have super stringent standards about stuff like spacing/which line braces go on/etc., the general rule is just "stay consistent within a file." So I have to kind of WTF when he makes a functional change to one line in a function and yet reformats the whole thing in his preferred spacing/brace format and renames all the variables. Really?
This is a very bad practice as it can also result in unnecessary merge conflicts. If a file is formatted a certain way, there needs to be a damn good reason to change it.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
02-07-2012 , 12:32 PM
Quote:
Originally Posted by Gullanian
Anyone experienced with PHPBB? We currently have an ASP.net website and Classic ASP forum. Our forum to be honest has been letting us down recently, half the problem with it is my fault from not really knowing what I was doing when I first integrated it months ago, and the other half is the forum itself. Some problems have been fixed, but it's so heavily ingrained in our website it would take a while to update, and I'd rather invest that time in installing a more stable forum. It's a mammoth job but our current forum gets a lot of complaints (daily) and is definitely holding back people from posting or using it regularly.

As far as other forums go PHPBB3 seems like the only one that supports MS-SQL server. There's no ASP.net forums that are any good last time I reviewed them. I've got PHPBB3 all set up and installed on my dev server ready to write the scripts to move all the data over.

However, on our site the forum is central to the user authentication. We have 1 login for the entire site which people love and is a lot better/simpler for users than having to setup mulitple accounts or keep logging in again.

It looks tricky to get IIS to share session data between PHP and ASP.net. PHPBB uses sessions to authenticate users and currently our site just uses cookies. Our current forum had an option to disable sessions and authenticate with cookies only which suited us best as it works across the entire site without any problems at all, all languages have access to those cookies.

Does anyone know in PHPBB3 if it's possible to disable sessions and use cookie authentication? Also if anyone has any suggestions would be appreciated, I really want to get it right this time as the current forum really just soaks up a lot of my time dealing with problems on it. If anyone has other better suggestions I'd love to hear them. It's a frustrating task for me as the site originally used PHPBB3, now I have to move it back! The original decision was made because I am experienced in Classic ASP for modifications, and it solved authentication problems by not relying on session variables. I'm deeply regretting it now because this has been a massive time soak and huge PITA (moving users from one authentication system to another is just a huge huge headache, moving the forum structure + posts is pretty easyish but time consuming), which is why I want to absolutely make sure I do everything right this time.
Last time I used PHPBB was about 4 years ago so things might have changed since then, but the biggest issue I had by far was spam. Because PHPBB is so widely used, there are some really sophisticated bots that can get round a lot of PHPBB's anti-spam measures.

Since you are going to be sharing authentication with the rest of your site, this might not be such a big problem as your singup procedure is likely to be unique.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
02-07-2012 , 02:01 PM
Gull, a PHP session usually involves cookies. You prob just have to do some digging to find out the cookie format so you can check from ASP it's contents or set it etc. I imagine it's gonna be documented how they work.

I would send a few PM to PokerAce, APerfect10 - If you've been following the PT4 beta or have uses PT3 in the past you may have noticed their pokertracker site uses a single login and has an integrated PHPBB forum, they might be happy to share a trick or two? But I suppose their whole site is probably PHP, not mixed ASP/PHP.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
02-07-2012 , 02:13 PM
Thanks, I've been posting on the PHPBB forum and the session data is actually stored in the DB which is handy as it will work across the entire site. It doesn't use HTTP sessions as I originally thought it might, this would be problematic as the data would be stored on the server largely inaccessible to other applications like ASP.net, so it should be fine to use it which is good news!
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
02-07-2012 , 03:20 PM
Quote:
Originally Posted by goofyballer
I'm going to be having an awkward conversation tomorrow. One of our other engineers basically reformatted half of a file that I own in his own coding style - we don't have super stringent standards about stuff like spacing/which line braces go on/etc., the general rule is just "stay consistent within a file." So I have to kind of WTF when he makes a functional change to one line in a function and yet reformats the whole thing in his preferred spacing/brace format and renames all the variables. Really?
Scripts to convert between different interpretations of style are pretty usefull. A standard is best ldo but dudex_to_standard.py can help a ton.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
02-07-2012 , 05:39 PM
Visual Studio Achievements Damn this makes me was to actually upgrade to 2010, Wonder how I could explain that request to management...
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
02-07-2012 , 05:41 PM
[ ] Achievement Unlocked: Add a link to your post.

** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
02-07-2012 , 05:44 PM
Quote:
Originally Posted by Benholio
[ ] Achievement Unlocked: Add a link to your post.

No idea what you are referring to, I def didnt have to quote someone to learn how to do quotes...

Sadly, we have many of those already

Last edited by Jeff_B; 02-07-2012 at 05:52 PM.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
02-07-2012 , 05:45 PM
VS achievements seems quite bizarre to me
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
02-07-2012 , 05:54 PM
Quote:
Originally Posted by Jeff_B
No idea what you are referring to, I def didnt have to quote someone to learn how to do quotes...

Sadly, we have many of those already
Sorry mate, I was just trying to point out that your link was broken.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
02-07-2012 , 08:11 PM
Quote:
Originally Posted by tyler_cracker
zurvan,

if i had a nickel for every "one-line change" that resulted in a huge, broken-ass commit (which the developer would have noticed with even a cursory diff review), i would not be in the job market right now.
Oh, don't I know it...

Although, I do control the deployment process, so that's actually when I do my diff
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
02-07-2012 , 09:48 PM
JFC lol we're being trolled pretty hard by an individual who keeps setting websites up and trying to sell our open source software.

If anyone wants to read about this guy it's a pretty hilarious story:
http://youfailit.net/?p=71

His incompetence is also breathtakingly stupid. View the source to this website of his:
http://www.thebestgamestudio.com/index.html

And look at the top HTML comment. At least it makes it easy to prove he's stealing off us. I've never come across someone so annoying and so utterly stupid, it makes me laugh. It's comforting to know it's not just us suffering him either.

It's a good learning experience going through various payment providers/hosts he uses seeing which ones are honest and are willing to remove a user from their service.

My experience so far is WePay don't give a hoot (only took it off after ignoring me repeatedly and me persisting), I consider their customer service to be appallingly bad.

1&1 interestingly are hosting that site of his and have ignored my emails so far. Perhaps we wont go with them after all if they decide to do nothing!

Paypal were actually quite good but you have to fill in some forms, and various small tiny webhosts are generally quite ****ty to deal with as they don't want to lose any customers at all.

Last edited by Gullanian; 02-07-2012 at 09:56 PM.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
02-07-2012 , 09:57 PM
ripping off your html is possibly enough to get the site taken down, find out where it's hosted and put in a copyright infringement claim. would be so much easier with sopa

But IIRC there isn't anything wrong with selling open source software? I can sell Debian install discs for £1000 a pop and that's perfectly fine (just tricky finding the customers lol). It doesn't seem to me like he's actually selling it at all?

Last edited by _dave_; 02-07-2012 at 10:00 PM. Reason: "Open source" obv depends on the particular license, can't remember bit IIRC was GPL?
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
02-07-2012 , 10:00 PM
Some users have reported to us that the executables he's distributing contain viruses. For some reason the file he serves is also bloated to about 300% it's actual size, I'm not going to touch it.

Selling open source software of course is technically fine, and we have had people doing it before in the past and haven't raised complaint with them.

However, he's claiming copyright ownership over the software, not distributing it with proper licenses as he should and also stealing our designs/html/css/graphics etc. Along with a long history of copyright theft/infringement.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD **
$25m Guaranteed WPM on CoinPoker
Join the action now
Daily Rewards • Splash Pots • CoinRaces
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD **

      
m