Quote:
Originally Posted by Zurvan
Reasonable code review is nice, it often spots issues that you can't see because yourself. Insane code review like that is somebody power tripping like a douche.
I agree with this, and I was actually quite happy to have someone reviewing my code when I started here, as it's probably the first job I have had where someone does this.
But when it comes to things like the following examples, it gets really annoying.
{t-sql}
Declare @tempVariable int
select @tempvariable = (Select count(0) from some table)
"WHY YOU USE SELECT, USE SET!!!!!!!!!!!!!!!!!!!!!!!!!"
or
Declare @GroupingType nvarchar(64)
--SMK:16 is enough
These lines of code have passed 6 code reviews, but suddenly they are an issue since my last check-in.