** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** - Page 896 - Computer Technical Help

Two Plus Two Forums Other Topics Computer and Technical Help

** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD **

Post Reply Subscribe

...

Page 896 of 1603

First

396 696 796 846 876 886 891 892 893 894 895 896 897 898 899 900 901 906 916 946 996 1096 1396

Last

Page 896 of 1603

First

396 696 796 846 876 886 891 892 893 894 895 896 897 898 899 900 901 906 916 946 996 1096 1396

Last

02-15-2016 , 09:57 AM

#22376

adios

Carpal \'Tunnel

Join Date: Sep 2002 Posts: 22,558

Quote:

Originally Posted by adios

I guess there are complexity analysis tools for JavaScript code and I am surmising from Russ's and GM's posts that they would rate code with more than 2 indent levels as highly/too complex.

Quote:

Originally Posted by gaming_mouse

yeah, those tools exist, i've used them for ruby, but there's no need for fancy code metrics or tools to see why nested indentation is bad. i mean, you can literally see it, right there in your editor, like digital vomit.

Quote:

Originally Posted by suzzer99

Ok indentation Nazis - tell me how this is bad code.

Code:

module.exports = function (grunt) {

    // All upfront config goes in a massive nested object.
    grunt.initConfig({
        html2js: {
            options: {
                // strip aways extra folder path info from templateKey 
                rename: function(moduleName) {
                    if (moduleName === 'xxx')
                        console.log("moduleName: " + moduleName);
                    ...

This is just a grunt task. Yeah I can define the rename function somewhere else. But whatever it's small and is easy to just throw in the config. This is pretty standard.

My point is there are massive levels of indentation all over the place. With AMD it seems like sometimes you're 4 indents in before you can even define a function you want to return with module.exports. So using 4 spaces instead of 2 just makes zero sense to me.

I was wondering if Suzzer would have something to state about this. What would a complexity checker for JavaScript indicate about this code?

Quote

150% up to $2,000 Welcome Bonus on CoinPoker

Join the action now

Daily Rewards ? Splash Pots ? CoinRaces

02-15-2016 , 10:46 AM

#22377

Grue

Pooh-Bah

Join Date: Mar 2004 Posts: 5,667

I like it. 4 "spaces" is easier to read than 2 for me. This is how I prefer to write JS. y u no es6?

Quote

02-15-2016 , 11:34 AM

#22378

jmakin

banned

Join Date: Jan 2008 Posts: 27,798

Embarrassing Monday confession:

2 years into programming I finally mastered breakpoints and the debugger. Previously I'd just been tracing code on paper or my whiteboard, lol. This is way easier.

Quote

02-15-2016 , 11:46 AM

#22379

Loki

binary duo

Join Date: Nov 2015 Posts: 12,772

what language?

I found C++ was terrible for breakpoints and debugging. Sitting there stepping into a simple call that went behind the scenes for like 25-40 steps was a huge PITA

Quote

02-15-2016 , 11:48 AM

#22380

Loki

binary duo

Join Date: Nov 2015 Posts: 12,772

also, y combinator considering 300 participants for a beta universal basic income program?

where do i sign up?

Quote

02-15-2016 , 11:51 AM

#22381

Benholio

Carpal \'Tunnel

Join Date: Jun 2004 Posts: 8,292

Quote:

Originally Posted by suzzer99

Ok indentation Nazis - tell me how this is bad code.

Code:

module.exports = function (grunt) {

    // All upfront config goes in a massive nested object.
    grunt.initConfig({
        html2js: {
            options: {
                // strip aways extra folder path info from templateKey 
                rename: function(moduleName) {
                    if (moduleName === 'xxx')
                        console.log("moduleName: " + moduleName);
                    ...

Nesting object properties isn't so bad, it's when you're nesting control structures several levels deep that it should set off alarms.

Quote:

Originally Posted by adios

I was wondering if Suzzer would have something to state about this. What would a complexity checker for JavaScript indicate about this code?

ESLint, for example, has no problems with Suzzer's snippet when max-depth is set to 2.

On the other hand, this would trigger an error:

Code:

/*eslint max-depth: [2, 2]*/

function foo() {
    for (;;) {
        if (true) {
            if (true) { /*error Blocks are nested too deeply (3).*/

            }
        }
    }
}

Quote

02-15-2016 , 11:54 AM

#22382

suzzer99

Save the Cheerleader, Save the World

Join Date: Nov 2005 Posts: 101,163

Right. But half the stuff I look at is object properties or something else that's not pure code.

Quote

02-15-2016 , 11:55 AM

#22383

gaming_mouse

Carpal \'Tunnel

Join Date: Oct 2004 Posts: 13,786

Quote:

Originally Posted by suzzer99

Ok indentation Nazis - tell me how this is bad code.

Code:

module.exports = function (grunt) {

    // All upfront config goes in a massive nested object.
    grunt.initConfig({
        html2js: {
            options: {
                // strip aways extra folder path info from templateKey 
                rename: function(moduleName) {
                    if (moduleName === 'xxx')
                        console.log("moduleName: " + moduleName);
                    ...

It's hard to say with such a small snippet, but based on what I see, yeah, I'm probably defining "rename" somewhere else so with ES6 it just says "options: { rename }".

I think pure config files are a different beast though, because those are essentially just a big object, and a nested data structure is far less problematic than nested control flow logic. Though even with data structures, excessive nesting does make them harder to look at, and I might consider defining it in pieces, so that the outer object makes reference to the named inner objects, rather than inlining them directly. That will cut down the visual indentation, though of course doesn't change the structure itself. I wouldn't necessarily do this in a config file, though, it would depend how long it was and how offensive it was to look it.

EDIT: ha, crossposted with ben who said almost the same thing

Quote

02-15-2016 , 11:59 AM

#22384

jmakin

banned

Join Date: Jan 2008 Posts: 27,798

Quote:

Originally Posted by Noodle Wazlib

what language?

I found C++ was terrible for breakpoints and debugging. Sitting there stepping into a simple call that went behind the scenes for like 25-40 steps was a huge PITA

C++. and yea that's why I was too lazy to bother with it. going through code with pen and paper is a good exercise though IMO

Quote

02-15-2016 , 12:00 PM

#22385

gaming_mouse

Carpal \'Tunnel

Join Date: Oct 2004 Posts: 13,786

Quote:

Originally Posted by suzzer99

Right. But half the stuff I look at is object properties or something else that's not pure code.

does it tax your brain at all to discern the overall structure?
do you find yourself folding a lot in your text editor to do so?

these are the kinds of cues i'd use to decide if it needed to be broken down.

Quote

02-15-2016 , 12:06 PM

#22386

suzzer99

Save the Cheerleader, Save the World

Join Date: Nov 2005 Posts: 101,163

Not really on either. I just want to maximize the amount of code I can see on the screen at one time. And right-left scrolling code is a huge PITA imo.

Quote

02-15-2016 , 12:12 PM

#22387

gaming_mouse

Carpal \'Tunnel

Join Date: Oct 2004 Posts: 13,786

Quote:

Originally Posted by suzzer99

Not really on either. I just want to maximize the amount of code I can see on the screen at one time. And right-left scrolling code is a huge PITA imo.

1) obvs use 2 space indentation/tabstop
2) turn on line wrap in your editor

left-right scrolling is the devil and unacceptable in any circumstance

Quote

02-15-2016 , 12:23 PM

#22388

greg nice

Carpal \'Tunnel

Join Date: Aug 2004 Posts: 10,001

if you stick to a ~80 char column width, then indentation problems take care of themselves. you're forced to refactor

Quote

02-15-2016 , 12:37 PM

#22389

suzzer99

Save the Cheerleader, Save the World

Join Date: Nov 2005 Posts: 101,163

Quote:

Originally Posted by gaming_mouse

1) obvs use 2 space indentation/tabstop
2) turn on line wrap in your editor

left-right scrolling is the devil and unacceptable in any circumstance

#1 Yes this is my whole point. I use 2 spaces. But if I take a job with this other group I will be forced to switch to four space tab stops.

I also don't get the people who like to develop in one tiny little code window in their IDE that they don't even take pains to maximize. I feel like I'm developing through a periscope.

Quote

02-15-2016 , 12:46 PM

#22390

gaming_mouse

Carpal \'Tunnel

Join Date: Oct 2004 Posts: 13,786

Quote:

Originally Posted by suzzer99

agree. the 4 space thing is annoying but not a reason to avoid the job per se. however, a preference for 4 spaces doesn't speak well of their taste, and bad taste certainly correlates, albeit imperfectly, with bad programming skill. but it's just a small red flag, so far -- you need to dig more. can you schedule a lunch with them... if they order their steaks well done, eg, you can politely decline the whole opportunity.

Quote

02-15-2016 , 12:53 PM

#22391

just_grindin

Pooh-Bah

Join Date: Dec 2007 Posts: 5,263

Quote:

Originally Posted by gaming_mouse

agree. the 4 space thing is annoying but not a reason to avoid the job per se. however, a preference for 4 spaces doesn't speak well of their taste, and bad taste certainly correlates, albeit imperfectly, with bad programming skill. but it's just a small red flag, so far -- you need to dig more. can you schedule a lunch with them...if they order their steaks well done, eg, you can politely decline the whole opportunity.

+1. Huge (un-)red flag.

Quote

02-15-2016 , 01:10 PM

#22392

suzzer99

Save the Cheerleader, Save the World

Join Date: Nov 2005 Posts: 101,163

Most of them are Indian. Doubt they'll be ordering steaks.

Quote

02-15-2016 , 01:11 PM

#22393

Loki

binary duo

Join Date: Nov 2015 Posts: 12,772

Just found out yesterday how to enable sublime's 80-char vertical rule. So happy.

Quote

02-15-2016 , 01:21 PM

#22394

gaming_mouse

Carpal \'Tunnel

Join Date: Oct 2004 Posts: 13,786

Quote:

Originally Posted by suzzer99

Most of them are Indian. Doubt they'll be ordering steaks.

lol

Quote

02-15-2016 , 02:00 PM

#22395

adios

Carpal \'Tunnel

Join Date: Sep 2002 Posts: 22,558

Quote:

Originally Posted by jmakin

Embarrassing Monday confession:

2 years into programming I finally mastered breakpoints and the debugger. Previously I'd just been tracing code on paper or my whiteboard, lol. This is way easier.

Quote:

Originally Posted by Noodle Wazlib

what language?

I found C++ was terrible for breakpoints and debugging. Sitting there stepping into a simple call that went behind the scenes for like 25-40 steps was a huge PITA

Quote:

Originally Posted by jmakin

C++. and yea that's why I was too lazy to bother with it. going through code with pen and paper is a good exercise though IMO

Step Over instead of Step Into to avoid going in the library code.

Quote

02-15-2016 , 02:07 PM

#22396

daveT

S.A.G.E. Master

Join Date: Jun 2005 Posts: 23,955

Maybe it is my Python background and maybe due to my ****ty eyesight, but I don't like 2-space indentations.

Quote

02-15-2016 , 02:29 PM

#22397

RogerKwok

grinder

Join Date: Apr 2009 Posts: 422

2-space indentation seems like a gateway to write super nested code

sure 4 takes more room but it's objectively easier to discern than 2, and if the code isn't over-nested, it's not a big deal