What I don't like is that 'month' and 'year' are local variables of the constructor. I'd rather declare them as private variables for the whole class, outside any function. And I wouldn't do elaborate things in a constructor, it should be as simple as
Code:
public LeapYear (int y, int m){
year = y;
month = m;
}
There can be a special function reading the user input of the real month and year values, like
Code:
public setYearAndMonth(){
try{
while(year<=0||year>=90000)
year = getIntFrmScn("Year");
while(month<0||month>13)
month = getIntFrmScn("Month");
}catch(Exception e){
System.out.println(e.getMessage());
}
}
The difference is that such architecture makes the class more universal. Another programmer might want to use the class but initialise its variables in another fashion out of another class; then it will be enough for him to call the constructor passing the values he wishes to assign as parameters, without the need to ask the end user to put the values in the way your fellow student has specified.
And more importantly, one would be able to allow the user to input the year and month many times without creating a new instance of a class. For this reason, there would ideally be special functions for variable change like this:
Code:
public changeYear(int y){
year = y;
}
Now, main() can first call the constructor with default values and then set its values properly:
Code:
public static void main(String[] args){
LeapYear instance = new LeapYear(0,0);
instance.setYearAndMonth();
instance.getDaysInMonthForYear();
}
(note that getDays now takes no parameters because 'year' and 'month' are passed to it automatically as class variables).
getIntFrmScn might as well be a made method of a separate class as ChrisV said, as its usefulness goes far beyond the scope of the LeapYear class, though it doesn't matter that much in a small program like this where I'd be too lazy to set up a second class just for the sake of one method.
Also, it looks strange to me that he writes the '...' in public static void main(String... Args), see
an SO question about the difference between '...' and '[]'.
Last edited by coon74; 04-16-2016 at 02:47 PM.
