If you're talking about formatting a lot - you're doing something wrong, imo.

I usually only talk about formatting when I'm working with a new developer (either new to company or new to codebase) in order to get them up to speed on the general styles being used or if there's a pattern of jarring style 'errors'.

But after that I'll let most things go because its a waste of time. The goal of the code review, imo, isn't to get perfect and beautiful code.

Yeah, I don't want to work with a developer that can't do this. I don't care about fancier algorithms and runtimes.

But if you don't know the basics I think you can get in a lot of trouble.

alright guess I won't harp on formatting especially since there's 5 people working on the same code.

But I literally said yesterday "don't use vanilla for loops, and especially don't use for in loops on arrays, use underscore each or array foreach" and sure enough 2 tickets "development complete" one with a for and one with a for in. Top minds at bangalore.

Funny story.

Some of you probably remember the Sony Pictures leak, where someone penetrated their network and found a folder with plan text passwords:

My CEO was at a conference/meeting/thingy and the CEO of Sony Pictures was presenting. My CEO is slacking me while he is there and felt kinda surprised when the Sony CEO says "there is nothing I would have done differently."

So he asked me "wasn't Sony storing passwords in plaintext?"

To which I responded, "Yes" and sent him an image of the above, and he found one online as well while I was sending it.

So they have a moderator led Q/A, and they ask people to write their questions down on paper.

Moderator asks Sony CEO my boss's question which is basically "You say you wouldn't have done anything differently, but weren't there tons of passwords being stored plain text on your servers?"

To which Sony CEO says "Yeah, that's not true"

Moderator laughs, looks at audience and says "Ha, nice try"

You can google this and find it everywhere, this guy is the CEO of Sony Pictures. The world we live in...

If you're dealing with outsourced developers, then I might actually be a lot more strict. Depends on the terms of the contract and how fast you need stuff done.

i am sure you are right and the guy is straight lying, but doesn't he have plausible deniability? he can say the screenshot is faked and the hackers were trying to make sony look bad, when what actually happened was a more sophisticated attack. or is there evidence against this?

I think what the hackers released is the actual content of these files, not just the screenshot.

With that said, I think these files are collected from a whole bunch of computers on the internal network and if you have that level of access at any large non-tech company, I'm sure you'd find something similar. This is certainly problematic but there's only so much technical talent and security awareness to go around.

You have a guy (Sony Ceo) that isn't very tech savvy, sure he can use the technology.., probably doesn't feel like the blame should be at him and is secretly angry at everyone; who'm should have told him, before it got to the current point in time. He has to be very aware, not slip up in conversation and not say anything that will worse with making stock fall by having bad press.

Seems like a weird or funny situation.

Yeah this is totally context-dependent. Also depends on the code base - if it's some application core that lots of things are dependent on, you want to be as strict as possible. If it's something peripheral and it doesn't matter too much if it breaks and is going to be rewritten according to the whims of some client in 2 months, maybe it doesn't matter as much.

You also need to think about the morale, culture, learning, etc and don't want the code review to devolve into an organizational checkpoint instead of an opportunity for everyone to talk about code and learn something from it.

There is substantial evidence and reporting on it. For example, that entire folder in that screenshot is supposedly available as a torrent right now.

Love the file called VARIANCE. Probably a copy of BBV right there.

We are designing a new ASIC and along with it firmware architecture right now, so lots of design work and writing of new code.

The ASIC is heavily concurrent with many CPUs in it, so it is a lot of designing around how to do concurrent actions safely and efficiently to get the most performance, then implementing and testing those designs.

Kato, you do hardware design? I had no idea. Hardcore.

Obviously faked I don't see 10,000 outlook note files anywhere.

I don't do the actual hardware design, I write firmware, which obviously is very close to the hardware - so we do have a lot of input on what features the hardware ends up having and how certain things are done.


My degree is in Computer Science but most of my coworkers have Computer Engineering or Electrical Engineering degrees.

That's pretty sweet. Sounds like something I would be interested in if I was farther along in my education/career.

We're looking for coops. How far along are you?

http://deadline.com/2015/06/sony-hac...es-1201445301/

They may still be involved in lawsuits.

Coincidentally had this on last night, Bruce Schneier talking about the Sony attacks for an hour or so

what exactly is a coop, btw?

Price wars in my area heating up between ISPs. Google 1gbps is $70. Comcast just sent an offer for 250mbps + TV/DVR for $70 a month. Our old bill was like $55 base for 50mbps, no tv.

They have to be bleeding subs in this area, I see the google van driving around here every day during the week.

Coop is just another term for intern.

Also, you kinda just gave away where you are from Roonil, in case you were wanting to keep that private.

there's 3 city/state combos with those two in competition, not sure how you mean.

In Lisp, you write (mod x y), so when you write "mod," know that you are using the One True Way.

I'm not sure why schools would have you using Oracle. Makes no sense at all. Once you are done, you won't be able to study Oracle unless you want to pay Oracle, which is awful.

Also, let the db-wars begin, the very things that Oracle people mock Postgres about is exactly what Postgres mocks Oracle about. Many a dead bodies have piled up over hinting. Also, Oracle has a query optimizer that is "too good." You can write some bad stuff and still get decent performance, which is kind of a backwards way of teaching SQL, in my opinion.

Not exactly O(), but in a database interview, speed of query execution is the main topic at a whiteboard. Certain topics don't matter as much, but for the most part, I've had to justify my answers with how long something will take, especially on the home tests.

Where I am, the topic of speed is paramount above all others, but the issues we are solving and dealing with sort of require it. My entire reason for existing is making the database fast.

Day one was much different than I thought it would be. I basically spent the day learning what the system is doing and then started working on some low hanging fruit. A few issues prevented me from doing so, but I feel like I understand the system and understand how I'll be useful. Oddly, I didn't feel the dreaded impostor syndrome, and I feel pretty good about this.

Guess we used to learn MySQL until recently. Not sure why the change, maybe local large employers wanted students who spoke the language. :shrug:

I remember back in the day when I used to have a job, there was this schedule job that did some database work which would take X amount of units and process them each for 10 mins or so. There was also a team dedicated to manually doing stuff with the output as it progress. At the company, the input of stuff that went into that process came in batches it was not a steady streamline of stuff going in. As a result sometimes the team of manual data entry people would have to sit around waiting for stuff to do.

Then one day our DBA was able to cut down that process to a couple of seconds each. He tested everything and made the change over a course of like 2 weeks. I don't remember the exact number, but we calculated the % of improvement, and ever since then we called him the Mr. 2033%.

It was so fast, that the management would sometimes come down panicking asking if there's anything wrong with the system.

Morale of story, O() matters, but sometimes it scares management.

The status quo is a power power thing...