Quote:
Originally Posted by Larry Legend
The commit history ime is the thing you don't need until you do.
its still there locally with a git reflog. but do you merge commits individually? or as part of a cohesive pull request?
like, lets say I am working on a feature. its pretty simple, say a button that sends some data.
so I make a new branch and I start working. I am a new dev or whatever but I dont do stashes or anything bc whatever. so heres my commit history.
-temp commit. needed to switch branches to check something.
-Boom, got the button on the screen YES!
-temp commit. changed branch to help Jeff.
-Sweet, got the data. still need to send it properly.
-Score! sending data now. WE are good.
-Fix all the unit tests
Ok, now I submit a PR. Why do I need all of those commits in the PR?
anyway, PR is up and obv there is feedback and I fix stuff and sometimes I miss the fdescrib or fit and or some other little thing and need to make a new commit.
-addressed feedback 1.
-oops forgot unit tests.
-addressed more feedback.
-on and on.
anway, I am saying that for each PR, it seems there should only be a single commit. more importantly, for each PR, there should only be a single merge.