Quote:
4. I don't find the "I copied other code so I shouldn't be judged for its problems" particularly compelling. There's an argument that consistency is good - and that may be an appropriate response. As in: "I followed what the other tests were doing, lets keep them consistent and we can create a separate story for refactoring everything at once". But there's also an argument that adding more bad stuff should be avoided and that you should start writing stuff in a better way as soon as possible
Quote:
after re-reading your post I guess the problem here was that you copied the methodology of the old tests, not that they thought you had written all of them. In that case you can kinda blame yourself, you should have written a correct test and ignored the others
just want to address this bc it makes me look bad but it is not really an accurate view.
yes, I copied the methodology, but it was not necessarily wrong. the tests worked properly and did the necessary testing. in fact, they followed the angular testing documentation.
https://angular.io/guide/testing
for various that I was not aware of at the time we are moving away from that methodology. again, thats fine with me. and I was happy to be shown the preferred way to structure the tests and rewrite them.
my problem was that I was tasked with rewriting all of the tests on the page. tests that I did not write or even touch. test that tested features that I did not write or alter.
still, I would not have had a problem with that if I had been given a story card so that I could get some credit for the work of rewriting a 300+ line spec file.
and yes, in the grand scheme it really is not a big deal and I shouldnt whine. but ya know, perspective is not always easy.