Open Side Menu Go to the Top
Register
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** ** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD **

08-03-2017 , 03:49 AM
Not surprised Node doesn't have a great auth lib at all. Most of these esoteric languages, like Node, Clojure, Haskell, Erlang, etc, don't have very good libs, and prefer configuration over convention.

Is it possible to just use a polyglot stack here?
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
08-03-2017 , 07:16 AM
Quote:
Originally Posted by suzzer99
Meanwhile I am begging for scraps of node work. This code was so bad I actually mentioned it to his boss, who was on the meeting yesterday. Also because I was ticked about the code bait and switch. His response was basically: yeah we can't find good node people, and only contractors are allowed to develop. Totally FUBAR.
suzz, I think you know how to proceed. lets see if you can pull 2 paychecks from the same company.

hell, your company sounds so clueless they will proly just let you interview yourself for the contracting gig.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
08-03-2017 , 12:57 PM
Suzzer maybe try sails?
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
08-03-2017 , 03:38 PM
Update on the terrible code above. Dev fixed everything I commented on. Still didn't fix when it was another instance of the same thing (like looping over an object just to access one property). He figured out he needs to use a promise for the async call, but still doesn't seem to understand as his promise is just returning the metadataObj to the ether.

I had an IM discussion with his lead.

Quote:
Me(12:22:52 PM): Is Dev's code supposed to be working code? I don't think it does anything. Even after his changes. I could be confused though

Dev's boss(12:23:26 PM): yeah it's supposed to cache the encrypted values from an API

Me(12:24:03 PM): I don't think this file does anything.

Dev's boss(12:24:30 PM): it doesn't call the metadata api?

Me(12:25:06 PM): it calls it, but the results go nowhere

Dev's boss(12:25:36 PM): they don't get cached? what it's supposed to do is save encrypted values and look them up so it doesn't have to call it every time

Me(12:25:57 PM): in the previous version the metadataCall() function returned metadataObj before the async call to the metadata api could come back

Me(12:26:24 PM): now the promise returns metadataObj to itself, not to the outer function I think

Me(12:26:50 PM): stuff might be getting cached, but there shouldn't be a useless return thrn

Dev's boss(12:26:51 PM): can you do a call with dev and someone else and tell them what you're seeing? I can set it up

Me(12:27:03 PM): i put it all in the comments

Me(12:27:50 PM): after the last call I'm not so sure. i didn't like the way dev had me review one batch of code, then switched to completely different code and expected me to review it over web-connect as he scrolled by. I feel like that was kind of a waste of my time to be honest

Me(12:28:51 PM): To be completely blunt, I don't think someone with this little understanding of node or JS should be writing a production app. We should push back for more experienced people.

Dev's boss(12:29:42 PM): ok apologies for that. I'll talk to him

Me(12:29:51 PM): vpn disconnected

Dev's boss(12:30:30 PM): oh I said, apologies for the call. I'll talk to him

Me(12:30:32 PM): well he's going to love me now

Dev's boss(12:30:53 PM): he's fine

Dev's boss(12:31:00 PM): he knows he doesn't know this well

Dev's boss(12:31:04 PM): he's pretty junior

Me(12:31:10 PM): yeah

Dev's boss(12:31:35 PM): we only have one experienced dev out of 7.

Dev's boss(12:31:42 PM): the rest are freshies

Me(12:31:53 PM): I don't get how that's possible

Dev's boss(12:32:03 PM): fixed bid contract
Bat**** ****ing crazy man. Get me out of here.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
08-03-2017 , 04:35 PM
Its hard to believe that code sample isn't the guy trolling hard.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
08-03-2017 , 05:22 PM
Quote:
Originally Posted by Victor
suzz, I think you know how to proceed. lets see if you can pull 2 paychecks from the same company.
lmao
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
08-03-2017 , 05:22 PM
This is definitely the type of stuff you see from bottom of the barrel offshore devs.

I've seen almost as bad from onshore Infosys type places too.

It's a scary world out there
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
08-03-2017 , 05:51 PM
I think I figured out what's going on with my group, and it's depressing.

Background is basically we're the architecture group that's supposed to feed into a bunch of internal and external sites and apps. We support one mega-site and a bunch of smaller ones. The mega-site team is generally the first group to implement the *next big thing*, which in this case is microservices. We're supposed to work with them to get a working prototype and turn it into an MVP, etc.

In reality though the mega-site team usually just throws away our stuff and does their own thing. It's a running joke with our team. In this case we've been talking about microservices for months, only to find out their team has already implemented a prototype of the whole platform.

What I think I figured out though is why this continues and nothing seems to be done about it. You'd think a group sucking in tons of funding to do nothing (which is mostly what I've had to do for a year) would eventually be a problem. However, both the mega-site team's boss and our boss have an incentive to say we’re feeding into his team when we’re really not. Our boss because he doesn’t want to lose funding, the megasite boss because he can say he’s taking guidance and then just do whatever he wants.

Beyond this particular situation, the whole feeding into/throwing stuff over the wall mentality is flawed. It wasn’t good on my old team when we had a "genius" architect shoving stuff down our throats then disappearing when things got tricky, and it’s not good in this situation. The teams need to be combined and integrated - so everyone is invested in the product all the way through production into maturity. You'd think that would be obvious.

I’m on these meetings and people say stuff like “I need 6 devs” for what should be a first-pass at brand new technology - done only by one senior dev or architect. It’s crazy - and you how you wind up with code like the stuff above.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
08-03-2017 , 05:52 PM
Quote:
Originally Posted by suzzer99
Update on the terrible code above. Dev fixed everything I commented on. Still didn't fix when it was another instance of the same thing (like looping over an object just to access one property). He figured out he needs to use a promise for the async call, but still doesn't seem to understand as his promise is just returning the metadataObj to the ether.

I had an IM discussion with his lead.



Bat**** ****ing crazy man. Get me out of here.
Does the company you work for have a process that incorporates code reviews and a defect logging/tracking system?
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
08-03-2017 , 05:55 PM
Quote:
Originally Posted by Victor
suzz, I think you know how to proceed. lets see if you can pull 2 paychecks from the same company.

hell, your company sounds so clueless they will proly just let you interview yourself for the contracting gig.
Unfortunately people have done that in the past. All contractors have to go through approved vendors.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
08-03-2017 , 05:56 PM
Quote:
Originally Posted by adios
Does the company you work for have a process that incorporates code reviews and a defect logging/tracking system?
Yes although it varies by group/project. But this dev seems to be on his own for some reason. Apparently the only senior dev on his team doesn't know anything about JS or node - which is why they're pulling me in from a different department for the code review.

I'm just completely fed up with the "yeah it's FUBAR but there's nothing we can do about it" mentality. I'm gonna keep being a blunt squeaky wheel until they fire me, move me, or give me something substantial to work on.

When you give someone code to review, and the feedback is "this person shouldn't be anywhere near a production app unsupervised", the response should never be "yeah, but what are you gonna do?". If you give that response you're part of the problem.

I feel like Gordon Ramsey coming into a disaster kitchen and they tell me they can't fire the cook who's so bad he's about to poison people - because reasons.

Last edited by suzzer99; 08-03-2017 at 06:05 PM.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
08-03-2017 , 07:12 PM
Uh I'm about to say something I never say, but wouldn't a unit test prove that that guy's garbage code doesn't even work?
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
08-03-2017 , 07:19 PM
Tomorrow is last day at $current_****show_job, on to the next one. At least its on React for real. Current one I was brought in to do a new project, I do almost all of it in React, it's 80% done and I'm told I have to remake it in Riotjs which turns out to be a ****show as well. fml.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
08-03-2017 , 07:23 PM
Quote:
Originally Posted by Grue
Uh I'm about to say something I never say, but wouldn't a unit test prove that that guy's garbage code doesn't even work?
What is this sorcery of which you speak?
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
08-03-2017 , 07:42 PM
Well this relevant: https://medium.com/@micaksica/your-n...g-f1a3bf831a46

Quote:
One of the more questionable things in Node.js development is that authentication is largely left as an exercise to the individual developer. The de facto authentication solution in the Express.js world is Passport, which offers a host of strategies for authentication. If you want a robust solution similar to Plataformatec’s Devise for Ruby on Rails, you’ll likely be pointed to Auth0, a startup who has made authentication as a service.

Compared to Devise, Passport is simply authentication middleware, and does not handle any of the other parts of authentication for you: that means the Node.js developer is likely to roll their own API token mechanisms, password reset token mechanisms, user authentication routes and endpoints, and views in whatever templating language is the rage today. Because of this, there are a lot of tutorials that specialize in setting up Passport for your Express.js application, and nearly all of them are wrong in some way or another, and none properly implement the full stack necessary for a working web application.
After reading that article I'm definitely going with Auth0. Now I know why they decided to go with Auth0 on the side job before I came on board. One of the only great decisions they made. At the day job it doesn't matter because we're always using some pre-existing auth service.

Hell I'd rather learn rails than try to go through the stuff the author describes from scratch.

If I had time I'd write a Devise for node. Seems like you'd have an instant audience. There has to be some reason that doesn't already exist.

Last edited by suzzer99; 08-03-2017 at 08:01 PM.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
08-03-2017 , 07:48 PM
Quote:
Originally Posted by suzzer99
Yes although it varies by group/project. But this dev seems to be on his own for some reason. Apparently the only senior dev on his team doesn't know anything about JS or node - which is why they're pulling me in from a different department for the code review.

I'm just completely fed up with the "yeah it's FUBAR but there's nothing we can do about it" mentality. I'm gonna keep being a blunt squeaky wheel until they fire me, move me, or give me something substantial to work on.

When you give someone code to review, and the feedback is "this person shouldn't be anywhere near a production app unsupervised", the response should never be "yeah, but what are you gonna do?". If you give that response you're part of the problem.

I feel like Gordon Ramsey coming into a disaster kitchen and they tell me they can't fire the cook who's so bad he's about to poison people - because reasons.
Leaving an inexperienced developer to their own devices while other departments do code reviews is ****ed up. Since interviewing is a popular topic here, could you describe what candidates go through in the hiring process when interviewing for both contractors and directs?
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
08-03-2017 , 08:05 PM
I have no idea since we got bought out and I haven't been around the hiring process of the parent co.

In the old days our boss would find people. Our bosses were so lazy we never knew when they'd bring in another candidate. So we'd give anyone a shot who seemed decent. Contract-to-hire was the usual way. So we weren't risking too much.

Then we hooked up with infosys and rarely hired any new employees and no contractors.

One reason I don't get these companies like Netflix demanding weekend-long projects and world class mega-rock star devs. Why not just hire anyone who shows promise to a 3 month contract or something? Or hell a month trial. You know almost immediately with a new dev if they're any good. But white board, interviews, homework projects - can be hit or miss.

I think they just like to suck their own ***** - as our beloved Mooch would say.

Last edited by suzzer99; 08-03-2017 at 08:11 PM.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
08-03-2017 , 09:00 PM
I'm not sure I follow that.

Based on your environment and experience, how does Netflix's hiring standards have anything to do with it?
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
08-03-2017 , 09:18 PM
I would not take a contract to hire job, most likely, so theres that. I want a job.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
08-03-2017 , 09:43 PM
Quote:
Originally Posted by Larry Legend
I'm not sure I follow that.

Based on your environment and experience, how does Netflix's hiring standards have anything to do with it?
Anything to do with what? I'm just talking about hiring strategies.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
08-03-2017 , 09:45 PM
Quote:
Originally Posted by RustyBrooks
I would not take a contract to hire job, most likely, so theres that. I want a job.
Well they could always hire the mega-rock stars and give the others a contract to hire chance. I probably wouldn't have taken it because I didn't want to move to SJ and my gf said she wasn't going to do long distance. But if it was in LA I would take contract to hire in a heartbeat if it looked like an interesting job.

My current job started as contract but after 6 months they offered me full time. The side job was hourly and after a few months they said they wanted to pay me straight 80% of a full time salary. Um, ok.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
08-03-2017 , 10:39 PM
Quote:
Originally Posted by suzzer99
Anything to do with what? I'm just talking about hiring strategies.
For me it would have seemed more logical if your point was "look at this insane code I reviewed... we have to use outsourcers who don't even know JS...the way we hire is broken... maybe Netflix misses people sometimes, but at least they seem to avoid anything resembling this experience".

Given what you've shared, it seems like people who do the exact opposite of what your company does may be doing it better, at least in a general sense.

As a data point, I know one person (other than a certain 2+2er) who works at Netflix, and he went from customer success to UI dev at the company we worked at, and then got a UI dev role at Netflix. So his background was at least a bit different than your cookie cutter CS degree from top school career engineer.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
08-03-2017 , 10:46 PM
As I mentioned - that insane code came from the parent company whose hiring practices I have no idea about.

From what little I gather overhearing in meetings it sounds like this:

Boss: How many people do you need for this bleeding-edge green-field app?

Employee: Um, 5?

Boss: Great, we'll write up a fixed-bid contract and get you 4 CS grads and a lead with 3 years of experience. In the meantime you are not to touch code. No touchy!


Regarding the rest, I was describing our hiring practice from years ago - before the parent co. came into the picture and the last time I was actively involved - which worked out ok for us.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
08-03-2017 , 10:55 PM
Quote:
Originally Posted by suzzer99
One reason I don't get these companies like Netflix demanding weekend-long projects and world class mega-rock star devs. Why not just hire anyone who shows promise to a 3 month contract or something? Or hell a month trial. You know almost immediately with a new dev if they're any good. But white board, interviews, homework projects - can be hit or miss.
I would think Netflix gets 1,000 applications per day and I would think there is a higher collection of viable candidates, being near all those colleges and stuff. How would they afford to churn that many developers every month?
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote
08-03-2017 , 10:58 PM
I would like to take this moment to say that the Shopify API is the most disastrous pile of flaming garbage I've ever had the displeasure of working with.
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD ** Quote

      
m