** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD **
09-18-2011
, 12:42 AM
09-18-2011
, 02:04 AM
Quote:
dave,
1. Use whitespace to separate your concepts
2. You always write:
when it's clearer and more concise to write:
If you want to visually suggest the bool type just name your methods using the "isXXX" convention, like "isStraight()".
Some larger design issues to consider:
1. You are mixing "presentation" and "logic" here. This method should probably return the name of the hand that you are printing, and the client code should print it.
2. Probably the most importatn thing. Your code is essentially checking a list of conditions in order, and returning the first one that matches. You should leverage python's functional programming abilities to accomplis this. It's been a while since I've done any python, so this is going to be psuedocode, but it should be clear enough. Rewrite the whole function in a few lines like this:
1. Use whitespace to separate your concepts
2. You always write:
Code:
boolStraight = straight(ranks)
if boolStraight == True:
Code:
if straight(ranks):
Some larger design issues to consider:
1. You are mixing "presentation" and "logic" here. This method should probably return the name of the hand that you are printing, and the client code should print it.
2. Probably the most importatn thing. Your code is essentially checking a list of conditions in order, and returning the first one that matches. You should leverage python's functional programming abilities to accomplis this. It's been a while since I've done any python, so this is going to be psuedocode, but it should be clear enough. Rewrite the whole function in a few lines like this:
Code:
handCheckers = [quads, flush, straight, etc]
foreach (checker in handCheckers)
if (checker(ranks, suits))
return checker.name;
****ing awesome post. Thank you sooooo much.
As for the rest of the team, I look like friggin' Dikstra in comparison. It is also clear that their 'new' site isn't so hot, and they got pretty well screwed over by the people they hired out last time. They want to have someone they can keep an eye on, but they don't know what they want or how to explain what they want.
The current site is dismal at best. There are massive errors in the presentation and usability. The most egregious example is that they have three columns of items as their main navigation. this wouldn't be so bad if they didn't have javaScript mouse-overs, so that when the pop-up window appears, it covers part of the nav menu. Okay, if this doesn't sound bad, then get this: when you mouse-off, the pop-up stays up on the screen so that the navigation menu is rendered useless.
Obviously the site is completely worthless without full js functionality. It looks like some guy just hacked together a bunch of jQuery and handed the site back.
The management who hired this guy is the same management who hired this new guy, so you can see where they are and you can at least see where I am.
As for adaquetly judging a programmer, well...
Can I blow the last guy out of the water? Yes I can. Can I blow this guy out the of the water? I can't really risk asking too many technical questions because I don't want to make myself look like I am capable of creating the APIs the site needs/wants to modernize.
I just had dinner with one of the managers, who I am friends with, and I couldn't help myself. I asked if this guy knew how to javaScript, and she said she didn't know. I also told her I was worried about the fact that he couldn't program at all in database and PHP, and she looked at me and said: "He doesn't do PHP?"
She them proceeded to tell me that they hired this guy because they really needed help maintaining and creating a MyAdmin account. He told us at the last meeting that databases wasn't his thing, so what good is he for this?
I think that when you are attempting to create a site of the difficulty of the one we are currently working on, it is not really a good idea to use a guy who will "probably" use Joomla! or Drupal. I would like someone who would say "I ~will~ use Drupal/Joomla/Magento/whatEver because 1 2 3 4 5."
Why? Because when this guy tells us that populating a database or XML to display only red coffee mugs on a web page is "too hard to do," I can't see how he would be qualified to create a site where our clients can log in to see order status, create orders with a secure log-in, and make the site accessible to people from the office to imput those order trackings.
Oh, and of course he is going to create a clickable slide-show without PHP or javaScript?
I can understand someone using a CMS to do all the above (plus way way more) but I am not confident in someone who knows absolutely no back-end at all and ~must~ use a CMS. At some point, I would like that guy using a CMS to be able to find the PHP files and tweak them to if they had to.
Obviously I'm not qualified to assess someone's programming prowess beyond a certain level, but this guy isn't very high level.
Also note that we aren't at the point where we are at CMS yet, so the web guy has to do all the above without a CMS unless he can convince management that's the only way. I'll def. block that assertion because it would appear to me that he is only buying time.
I have to take control of this disaster and take the fall, IMO. At least the disaster won't be as bad. Call it damage control.
Last edited by daveT; 09-18-2011 at 02:09 AM.
09-18-2011
, 04:39 AM
09-18-2011
, 10:54 AM
09-18-2011
, 04:51 PM
09-19-2011
, 12:59 PM
09-19-2011
, 07:54 PM
