Two Plus Two Publishing LLC
Two Plus Two Publishing LLC
 

Go Back   Two Plus Two Poker Forums > >

Notices

Programming Discussions about computer programming

Reply
 
Thread Tools Display Modes
Old 06-10-2020, 10:51 PM   #39701
Victor
Carpal \'Tunnel
 
Victor's Avatar
 
Join Date: Jul 2003
Posts: 63,868
Re: ** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD **

I know this is blasphemy but I dont think unit testing is worthwhile. better time spent elsewhere.

now, I love unit testing. I like to write code and I learn a lot writing tests bc I like to challenge myself and the frameworks and the code in general. but spending an entire day or more on just a couple tests surely isnt worth it. esp when most unit tests boil down to true=true. and the ones that take time are bc I am trying to prove something to myself about how the code works.

and depending on the work you do, damn near all devs are gonna test their actual code on locally or on a dev server regardless of the tests they write so whats the point?
Victor is offline   Reply With Quote
Old 06-10-2020, 11:03 PM   #39702
suzzer99
Save the Cheerleader, Save the World
 
suzzer99's Avatar
 
Join Date: Nov 2005
Location: givin' 'em the business
Posts: 96,711
Re: ** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD **

The point is when you have to go back to some code 6 months later and you don't remember anything about how it all works - good unit tests will save you from a day of wrestling with it to understand it again.

Our Facebook login stopped working Tuesday. For some reason Facebook and Google integrated with AWS cognito had always returned nothing for email_verified (the field didn't exist). Whereas cognito would return true or false for users who signed directly. So I had a check for email_verified === false, which worked fine.

But then all of a sudden Google starts showing up as email_verified = true for all users and Facebook as email_verified = false for all users. Fun stuff. Because of my unit tests I was able to quickly find all the spots where I needed to change the logic, and be confident I could push a hotfix w/o worrying about breaking something else.

As a one man show on a lot of my stuff with no testing team to speak of, good unit tests (and integration and e2e tests) allow me to wrangle a large code base with an order of magnitude less effort than if I didn't have them - even taking into account the effort up front to write the tests.
suzzer99 is offline   Reply With Quote
Old 06-11-2020, 04:42 AM   #39703
OmgGlutten!
Pooh-Bah
 
OmgGlutten!'s Avatar
 
Join Date: Aug 2016
Posts: 5,239
Re: ** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD **

Tests make a big difference as the framework changes and u have to go rewrite stuff. Maybe less relevant on the front end where stuff is usually more isolated by default.
OmgGlutten! is offline   Reply With Quote
Old 06-20-2020, 03:52 AM   #39704
DontGoft
newbie
 
Join Date: Sep 2019
Posts: 45
Re: ** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD **

Quote:
Originally Posted by Biggle10 View Post
The part I'm struggling with mentally is the time to do it. I've read plenty where people say once you're used to it it doesn't add that much more time to your DEV process and saves time in the long run. But for example, management/product owner says how long will it take to do feature x. I say a week as I am including some time to write tests, etc. Management says is there anyway to make that faster as customer really needs that feature right now and a week seems too long. Since I'm new to unit testing stuff, I could do it faster if I ignored it but I'm not sure how to answer that question then to management.

As an aside, that particular manager is no longer here and the way we do estimation is different now, but I'm reflecting back on how I could've/should've done things differently.
Probably the type of management you are describing doesn't care about unit testing.

I've been there, and it is tough, but how you address that, it depends.

You just say your time, don't say it takes my five days, but without test, it takes me two.

First, you decide if you do test or not. Ideally, you should always do unit testing, but there are some factors that maybe you shouldn't do it.
Maybe it is a legacy product, and if you do unit tests, it will take you forever.

Unit testing is a trade-off between cost now and benefits later.

But the thing is you need to deliver a quality product, and if you feel your product is going to decline in quality if you don't do unit testing (probably bugs), then you need to do unit test no matter how long it is going to take.
DontGoft is offline   Reply With Quote
Old 06-28-2020, 01:51 AM   #39705
Aceium
Carpal \'Tunnel
 
Aceium's Avatar
 
Join Date: Jan 2007
Location: Kansas City
Posts: 7,328
Re: ** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD **

If anyone in here has played Hearthstone, I have a question for you.

How would you describe the lag in the transition that occurs when you find a Worthy Opponent while searching for a game? - In terms of computation?
Aceium is offline   Reply With Quote
Old 06-28-2020, 02:35 PM   #39706
_dave_
_Pooh_Bah_
 
Join Date: Feb 2005
Location: UK (or what remains of it)
Posts: 13,079
Re: ** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD **

Quote:
Originally Posted by Aceium View Post
If anyone in here has played Hearthstone, I have a question for you.

How would you describe the lag in the transition that occurs when you find a Worthy Opponent while searching for a game? - In terms of computation?
Matchmaking time, if that's what you're asking
_dave_ is offline   Reply With Quote
Old 06-28-2020, 04:13 PM   #39707
Aceium
Carpal \'Tunnel
 
Aceium's Avatar
 
Join Date: Jan 2007
Location: Kansas City
Posts: 7,328
Re: ** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD **

I assumed that the matchmaking was happening while the spinner was spinning. Before you enter the match, the spinner seems to stall and hang for a couple seconds before it shows "Worthy Opponent". I'm wondering what would cause this type of lag before almost every game. It seems very un-Blizzard from a polish perspective.
Aceium is offline   Reply With Quote
Old 06-29-2020, 11:19 AM   #39708
jmakin
DoorDash Balla
 
jmakin's Avatar
 
Join Date: Jan 2008
Location: Streaming
Posts: 29,070
** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD **

Shitty app. It also sometimes forgets its screen orientation so you need to flip your phone over and back again to fix it.

When theyíve had these bugs for years and donít fix them you can assume itís just bad design, IMO
jmakin is offline   Reply With Quote
Old 06-29-2020, 01:51 PM   #39709
Aceium
Carpal \'Tunnel
 
Aceium's Avatar
 
Join Date: Jan 2007
Location: Kansas City
Posts: 7,328
Re: ** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD **

That's kind of why I brought it up. It seems unlike Blizzard to have that sort of an "eyesore" in their game for a long time, unless it's exceedingly hard to fix. I would love to hear one of their systems guys talk about the challenges of keeping the Unity experience smooth.

Something like, "Yeah that's an annoying hiccup, but in order to fix it we would have to totally redesign the whole process of playing a game, and we don't want to break more stuff by trying to smooth out that transition. The transition might be smoother but there's a possibility we would go back to the days of minions spontaneously moving around on the board, which is worse than the matchmaking lag."
Aceium is offline   Reply With Quote
Old Yesterday, 01:03 PM   #39710
Biggle10
veteran
 
Biggle10's Avatar
 
Join Date: Jul 2005
Location: St. Louis/ Ultimate Frisbee pitch
Posts: 2,926
Re: ** UnhandledExceptionEventHandler :: OFFICIAL LC / CHATTER THREAD **

Quote:
Originally Posted by Aceium View Post
I assumed that the matchmaking was happening while the spinner was spinning. Before you enter the match, the spinner seems to stall and hang for a couple seconds before it shows "Worthy Opponent". I'm wondering what would cause this type of lag before almost every game. It seems very un-Blizzard from a polish perspective.
I've noticed that too. When I first started playing I thought the app was freezing, now i don't even notice it really as its just part of the start game process.
Biggle10 is offline   Reply With Quote

Reply
      

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off


Forum Jump


All times are GMT -4. The time now is 02:17 AM.


Powered by vBulletin®
Copyright ©2000 - 2020, Jelsoft Enterprises Ltd.
Copyright © 2008-2017, Two Plus Two Interactive
 
 
Poker Players - Streaming Live Online