Quote:
Originally Posted by Larry Legend
I need some advice.
New co-worker is turning out to be fairly toxic and also lazy. He's also prone to acting like a know-it-all. Today I reviewed code of his and mentioned his error handling is a bit broad. That handling all API error responses with a hard coded string isn't ideal. He responds that the response is being wrapped by something and he can't access the response object directly. I mention that I wrote code recently that he saw that handled multiple potential error responses, he gives me a flippant response about of course he saw my code but his situation is different.
I checked his code and and literally .catch((data) => {console.log (data) } logs a very nice complex API response that even includes the exact same error message for this specific error that he is hard coding for all errors.
How have you been communicating with him so far? If it was just on the PR, I would try to discuss this in private since people tend to be more defensive in public and it can be a little awkward for a new guy to defend his reasoning even if it seems correct to himself (not worth it is a valid reason but depending on the culture people may be reluctant to write it where everyone can see it). Also how new is he?
Quote:
A) speak with our manager (vp responsible for dept)
B) speak with a senior backend engineer and get his take on how to handle it (I liked this at first but now I'm thinking against it)
C) speak to colleague directly, being gracious, giving him a chance to redeem himself
D) ignore the situation and just find another job soon (i see more things like this coming though if nothing is done)
E) something else
Unless you've already talked to him in person and/or have had these types of issues repeatedly, you may be overreacting a little. I mean, it sounds like it probably won't work but kind of like how HR uses PIP, you want to exhaust your options not because they are likely to solve the problem but so that you can say you've tried all that you could. They help document the problem and make it easier to jump to more extreme means.
Quote:
Potentially of note. A project he was on and I wasn't missed a Friday deadline so I worked on it to help out over the weekend. The tasks I took were very simple and I spent ~2 hours on them total, I would expect a 5-7+ year developer to be at least as fast as me on these tasks and have completed them easily in the time provided.
I know you can't help but make this kind of comparison but generally speaking people don't become necessarily faster as they become more experienced beyond a certain level (and that level may be some time in college for many), especially on simple tasks. It's possible that you're just fundamentally good in a way this guy isn't and never will be. It's also possible he's just not ramped up properly on the code base or the tech stack or whatever he needs to become productive there.