Quote:
Originally Posted by Larry Legend
Dude, you did not make yourself look extremely stupid.
I had a dev with 30+ years of experience ask me to review a PR that both broke the build and was pointed at the wrong branch.
I calmly let her know and she seemed pretty embarrassed but I reacted like a calm, well-adjusted cool person and not like a flaming douche so the embarrassment left her and she had it fixed shortly after.
You don't look "extremely stupid" you haven't even graduated yet ffs!
the thing was i actually did end up fixing it and knew what the problem was but i stated it in a way that was haphazard and not tested completely. and honestly idk how the **** to make great build files, i just knew that what I had worked and i identified the problem but forgot to modify the associated makefile that had the problem.
but he probably had already figured it out or something, idk. I felt really, really stupid, especially after our encounter in the bathroom right after.
i'm just gonna tell someone else how to fix it and let them deal with it.