I have the 2nd edition, and it's 2017. A good read.

Getting promoted and I’m going to have a performance review today. Will know what my salary bump is. If the salary bump misses my expectations of where I want to be, how do I voice that without sounding greedy? Or do I just take it and not say anything?

We have an internal google sheet with salaries posted that employees share, so I have an idea what the range should be for the next level. I just hope my base which is anchored slightly lower than others does not impact my raise so much.

If it's public information I think it's totally reasonable to bring it up in the review, especially given that a promotion is in response to performance. It sounds pretty reasonable right: "If my performance merits this promotion, doesn't it also merit bringing my compensation in line with others in my same position?"

You should just have a plan for how you want to react if they disagree :P

Congrats barrin

Nothing wrong with being greedy.

gj barrin, I like well named's suggestion.

You should ask two questions.

1) How is compensation determined in general
2) Whether there's a compensation range for a given level, if so what the range is for your new level and how it's determined where you end up within that range.

With that said, it should be expected that you're on the lower end of the comp range for the new level, if you're getting promoted into that level, assuming that this is how the comp is determined at the company. Also, depending on how the company is run, some people may be above the normal compensation band for the range, especially if they are recent hires. Also, people may or may not be telling the truth on the google sheet.

Tell them you disagree with their assessment and that you’re gonna have to test the market. If they think their pay is in line with the market, they should simply shrug.

No idea if that’s good advice. I just want you to do it and report back. And also to actually test the market.

So just got back, didn’t get a chance to discuss compensation changes. That stuff gets released next week.

We just went over what was written for the performance review and nothing else.

It's unlikely to be public information - it sounded like something a bunch of people are sharing, probably anonymously, to get a sense of whether they are getting screwed.

Before you do something like this, it's important to ask yourself, what are you trying to accomplish?

It's likely that 1) his manager had to do some extra work to get him the promotion but 2) doesn't have any power over his compensation, especially this late in the process. So making it clear that you're unhappy with your compensation because of your promotion is basically punishing the manager for helping you get promoted. It's highly unlikely to have any positive impact, especially given the timing - right when you receive your raise is not a good time to ask for another one.

I think I gave this advice before but if you're angling for a raise (or a larger than normal raise), the correct thing to do is to show interest in your compensation well ahead of time as to have this be taken into account during the entire decision-making process. It's generally too late to bring this up when you're presented with a raise.

Agree with candybar here. Some very good advice, thanks!

As for the spreadsheet, this was started by someone in the company slack channel when they were talking about pay transparency, a question directed to the execs. An ex-googled then said “we solved this problem at google, I’ll just create one and have everyone submit anonymously!” So that’s how it got started, it’s not an official salary guide and yes people can lie.

I don’t know what my raise is like still but I will bring it up in discussions in the next 1 on 1 if it is below my expectations. That way I can get the conversation started on what I need to do to bring my salary to the expected level for the next performance review.

Re: jmakin's 2nd interview question I was reading about grammars the other day and I thought this would be a perfect example of some type of grammar parser which led me to Google and find this:

https://lukaszwrobel.pl/blog/math-pa...-introduction/

I think all the articles are interesting and loosely tie together theory and implementation in a nice way.

Always fun to think about these types of string manipulation questions in python where these questions end looking like
"reverse a string" --> str[::-1]
"evaluate this expression" --> eval(str)
"is the binary representation a palindrome" --> bin(x)[2:] == bin(x)[:1:-1]
etc.

Although I guess "any language" meant both C and C++ in this case :-)

Right but that just shows your familiarity with python, right? It doesn't really show how well you either reason about unknown problems or demonstrate your exposure/familiarity with well known problems.

My answer to Q1:

I assume that by C you mean a language with a one letter name. Hence:

Try it online!

Well this is horrible advice.

1) if you want to leave, get another offer and leave.

2) if you want to stay for more money, get another offer and plan to leave unless they match/beat the offer.

In either case, you have to be ready to walk away from the company if you mention you're looking around or have other offers.

Yeah I don’t think that’s true. The feeling I get these days is that everyone assumes that anyone who is ambitious at all is already planning their next step, just a question of when and for how much. The company they’re at now just has an inside track to retaining them, like with signing football players.

Meaning, show me one anecdote of a software dev hinting that he might leave, alarming his manager into scrambling to find his replacement, resulting in undercutting his leverage or getting him fired. You won’t find it. It’s monsters under the bed.

Also, come bonus or annual review time, if your manager isn’t worried that you might leave, you’re either a schmuck or a B player. Stop being those things.

I think it depends on the manager, but I tend towards iversonian. Nothing wrong with being direct that you want more money or you'll look elsewhere if you are an A player.

anyone bother with javascript decorators? I can't tell if they're actually a thing that is for reals coming in the spec. eslint isn't happy about them.

It's hard to imagine them not becoming increasingly common in react libraries. Some of the ones we use already support them, and I see react core continuing to use them more over time.

barrin is almost certainly a rock star or something close to it, he could afford to be aggressive about it

No. If they were syntactic sugar for ordinary function wrapping, I'd like the feature, but since I never use js classes I'm out:
And decorating with pure functions is natural and lightweight anyway in js.

ok cool. They're used or suggested to be used by higher order functions in react (obv redux/mobx, but also react-dnd). I'll not bother as ffs who needs random weird @ characters in their code that make no sense beyond "this is cool" code hipsters.