Quote:
Originally Posted by clowntable
It's the great debate of job interviews, should you point it out or not
I always viewed it as a positive if they found it and pointed it out. Means they have an eye for detail, value quality code enough and most importantly aren't scared to speak up.
The problem is, it almost always comes off as arrogant and ignores the greater context.
The code is on a whiteboard, so it could be:
* Another candidate's code
* A brainstorming session where syntax obviously isn't that important
* Old code they want to refactor
* And so on...
Even worse is pointing out flaws in the code base because again it ignores things like:
* It's legacy code that is too expensive to fix
* It's code that had to be shipped in a hurry
* It's code still undergoing QA
I have no desire to work with someone that points out every little thing wrong in a project. It just isn't productive in the big picture.
I'm also slightly biased because I worked with a guy once who would point out every little flaw in our code and write long emails pointing out problems and giving suggested refactorings - while I was working 70-80 hour weeks and the team was working 50-60 hour weeks just to meet a major contractual obligation.
Guess what, perfect test coverage and well designed code is going to slip a bit when business needs say that it has to. And while its some of the ugliest code I've ever written - it's also the project that I'm most proud of.