Two Plus Two Publishing LLC
Two Plus Two Publishing LLC
 

Go Back   Two Plus Two Poker Forums > > >

Notices

Free Software Discussion of Free / Freeware / Donationware / Open Source poker software and Free Graphics mods

Reply
 
Thread Tools Display Modes
Old 11-03-2008, 11:44 PM   #626
Eleatic Stranger
journeyman
 
Join Date: Sep 2008
Location: Sydney
Posts: 292
Re: New Free/open source poker tracking software: FPDB - (Alpha6 - bugfix) - 04-Oct-2

Quote:
Originally Posted by Eratosthenes View Post
Real multitabling support has been added to the fpdb git tree, mostly due to the work of ekdikeo (yeah, we have 4 developers now--all are welcome). Stat windows will be appropriately hidden when you are using cascaded/stacked tables.
This is fantastic news. I have downloaded this version and will report on any problems, or with further suggestions if I have them.
Eleatic Stranger is offline   Reply With Quote
Old 11-04-2008, 03:14 AM   #627
ekdikeo
old hand
 
Join Date: Aug 2006
Posts: 1,308
Re: New Free/open source poker tracking software: FPDB - (Alpha8 - bugfix) - 17-Oct-2

eleatic: i've been waiting for you to pop in and check this out I've found that minimizing the windows does not make the huds go away properly (future changes planned to make this work, im just researching if i have to write it myself, or if i can set something somewhere that will cause windows/an x window manager to deal with it for me) .. but as long as you aren't the type that minimizes every window that you're not immediatly looking at, it should work out right.

I have run 3 and 4 tables with it, with very few problems, on a site that isn't technically "supported"
ekdikeo is offline   Reply With Quote
Old 11-04-2008, 07:03 AM   #628
Eleatic Stranger
journeyman
 
Join Date: Sep 2008
Location: Sydney
Posts: 292
Re: New Free/open source poker tracking software: FPDB - (Alpha8 - bugfix) - 17-Oct-2

Quote:
Originally Posted by ekdikeo View Post
eleatic: i've been waiting for you to pop in and check this out I've found that minimizing the windows does not make the huds go away properly (future changes planned to make this work, im just researching if i have to write it myself, or if i can set something somewhere that will cause windows/an x window manager to deal with it for me) .. but as long as you aren't the type that minimizes every window that you're not immediatly looking at, it should work out right.

I have run 3 and 4 tables with it, with very few problems, on a site that isn't technically "supported"
I’m not surprised to hear it works with “unsupported” sites; in its current state the HUD seems very robust.

I’ve had a chance to try the HUD out to the tune of a few hundred hands with my standard arrangement of eight stacked tables (though I usually play on more than eight). It ran entirely without (significant) fault. More testing to follow. Everything is as advertised. This is a real quantum leap in the quality of the user-interface. Well done!

I have come across three slightly strange bugs, though extremely trivial ones. Firstly, some of the tables seemed not to get their HUD straight after the first hand had been played, but after a few hands. Perhaps a new HUD appears only if the table is currently visible? Secondly, while the HUD is running (I think) and after it has been closed the Fpdb main window stops responding. When I then press ctrl-C in the terminal window (in which the error messages appear), the automatic importing stops and the main window wakes up again. Since at this point I just want to quit, this doesn’t matter. Thirdly, for some reason the statistics window for seat 9 (nine-handed on Poker Stars) is sometimes, but not always, slightly out of position (about 20 pixels to the left of where it should be).

I didn’t try to minimize any of the windows while playing as this seems pointless, so I would tend to regard this “bug” as trivial as well.

Once again, my congratulations to the developers!
Eleatic Stranger is offline   Reply With Quote
Old 11-04-2008, 08:38 AM   #629
sorrow
old hand
 
sorrow's Avatar
 
Join Date: Apr 2008
Location: Perth, Western Australia
Posts: 1,531
Re: New Free/open source poker tracking software: FPDB - (Alpha8 - bugfix) - 17-Oct-2

Quote:
Originally Posted by Eleatic Stranger View Post
I’m not surprised to hear it works with “unsupported” sites; in its current state the HUD seems very robust.

I have come across three slightly strange bugs, though extremely trivial ones. Firstly, some of the tables seemed not to get their HUD straight after the first hand had been played, but after a few hands. Perhaps a new HUD appears only if the table is currently visible? Secondly, while the HUD is running (I think) and after it has been closed the Fpdb main window stops responding. When I then press ctrl-C in the terminal window (in which the error messages appear), the automatic importing stops and the main window wakes up again. Since at this point I just want to quit, this doesn’t matter. Thirdly, for some reason the statistics window for seat 9 (nine-handed on Poker Stars) is sometimes, but not always, slightly out of position (about 20 pixels to the left of where it should be).

Once again, my congratulations to the developers!
This is good news. The hud windows should appear after 2 hands. I haven't tracked it down yet, but it is consistent.

With the 20 pixels measurement, what corner is out? top left? the windows resize to compensate for stats - i haven't looked at how that is done yet.

Haven't seen the hud main window hang yet, i'll keep an eye out, i'm sure Ray will read this soon.
sorrow is offline   Reply With Quote
Old 11-04-2008, 08:56 AM   #630
Eratosthenes
old hand
 
Join Date: Oct 2004
Posts: 1,535
Re: New Free/open source poker tracking software: FPDB - (Alpha8 - bugfix) - 17-Oct-2

Quote:
Originally Posted by Eleatic Stranger View Post
I have come across three slightly strange bugs, though extremely trivial ones. Firstly, some of the tables seemed not to get their HUD straight after the first hand had been played, but after a few hands. Perhaps a new HUD appears only if the table is currently visible?
This is actually happening in the importer. It seems to be noticing the new hh file and putting it on the list of files to watch, but doesn't actually import from it until the 2nd hand goes in. I think this is something we can fix.
Quote:
Secondly, while the HUD is running (I think) and after it has been closed the Fpdb main window stops responding. When I then press ctrl-C in the terminal window (in which the error messages appear), the automatic importing stops and the main window wakes up again. Since at this point I just want to quit, this doesn’t matter.
pytgtk programs do not respond correctly to ctrl-Cs. They have a hack in their FAQ that makes ctrl-Cs work, but it uses a lot of cpu to watch for that signal--meaning we probably don't want to use it. Closing the fpdb window exits more gracefully.
Quote:
Thirdly, for some reason the statistics window for seat 9 (nine-handed on Poker Stars) is sometimes, but not always, slightly out of position (about 20 pixels to the left of where it should be).
This is weird. I have not seen that, so I'll play some holdem and see if I can replicate it.
Eratosthenes is offline   Reply With Quote
Old 11-05-2008, 12:30 AM   #631
Eleatic Stranger
journeyman
 
Join Date: Sep 2008
Location: Sydney
Posts: 292
Re: New Free/open source poker tracking software: FPDB - (Alpha8 - bugfix) - 17-Oct-2

Quote:
Originally Posted by sorrow View Post
With the 20 pixels measurement, what corner is out? top left? the windows resize to compensate for stats - i haven't looked at how that is done yet.
The whole window appears slightly to the left of where it should (and of where it actually does appear on most of the tables – the fault occurs only sporadically). I didn’t actually count the pixels. My theory is that this is an artifact of unwanted interaction between different threads (trying to display the window and update the statistics at the same time); I came across something similar when I hacked the earlier version.

Quote:
Originally Posted by Eratosthenes View Post
[The importer] seems to be noticing the new hh file and putting it on the list of files to watch, but doesn't actually import from it until the 2nd hand goes in. I think this is something we can fix.
If it’s consistently two hands I wouldn’t bother to “fix” it. It’s not a bug; it’s a feature.

Quote:
Originally Posted by Eratosthenes View Post
pytgtk programs do not respond correctly to ctrl-Cs.
Strange; I’ve always found them to respond correctly, except perhaps in this case. As I said, you hit ctrl-C, and like magic the main window starts responding again.
Eleatic Stranger is offline   Reply With Quote
Old 11-05-2008, 05:20 AM   #632
Eleatic Stranger
journeyman
 
Join Date: Sep 2008
Location: Sydney
Posts: 292
Re: New Free/open source poker tracking software: FPDB - (Alpha8 - bugfix) - 17-Oct-2

I’ve had another try – about 400 hands. The HUD stayed operational during the session, but some minor bugs showed up.

The problem of the “misplaced” stat window is a bit worse than I thought. Sometimes they all get misplaced. They appear right on top of the window that says “right click to close HUD” and on top of one another and have to be positioned manually. This only happens on some of the tables. I will make efforts to find out what is going wrong.

The pop-up windows don’t work correctly with the HUD’s new appearing-and-disappearing behaviour. If you are unlucky and happen to open one a moment before a new poker table jumps to the front of the queue, you can’t close it any more. It stays there hovering over what is now the wrong table and won’t go away.

That said, once these difficulties are ironed out I think the HUD will be a must-have piece of software.
Eleatic Stranger is offline   Reply With Quote
Old 11-05-2008, 06:26 AM   #633
Eratosthenes
old hand
 
Join Date: Oct 2004
Posts: 1,535
Re: New Free/open source poker tracking software: FPDB - (Alpha8 - bugfix) - 17-Oct-2

Quote:
Originally Posted by Eleatic Stranger View Post
If it’s consistently two hands I wouldn’t bother to “fix” it. It’s not a bug; it’s a feature.
There have already been 2 changes comitted to fix this. I haven't tested them.
Quote:
Strange; I’ve always found them to respond correctly, except perhaps in this case. As I said, you hit ctrl-C, and like magic the main window starts responding again.
Sorry, you're right, I misread the FAQ.
Quote:
Originally Posted by Eleatic Stranger View Post
The problem of the “misplaced” stat window is a bit worse than I thought. Sometimes they all get misplaced. They appear right on top of the window that says “right click to close HUD” and on top of one another and have to be positioned manually. This only happens on some of the tables. I will make efforts to find out what is going wrong.
This indicates that all the statwindows are opening at (0,0) relative to the poker client window. It seems the the HUD code is not getting the layout from the config properly.
Quote:
The pop-up windows don’t work correctly with the HUD’s new appearing-and-disappearing behaviour. If you are unlucky and happen to open one a moment before a new poker table jumps to the front of the queue, you can’t close it any more. It stays there hovering over what is now the wrong table and won’t go away.
This one we can fix.
Eratosthenes is offline   Reply With Quote
Old 11-05-2008, 10:25 PM   #634
sorrow
old hand
 
sorrow's Avatar
 
Join Date: Apr 2008
Location: Perth, Western Australia
Posts: 1,531
Re: New Free/open source poker tracking software: FPDB - (Alpha8 - bugfix) - 17-Oct-2

Quote:
Originally Posted by Eratosthenes View Post
This indicates that all the statwindows are opening at (0,0) relative to the poker client window. It seems the the HUD code is not getting the layout from the config properly.This one we can fix.
I've seen this a couple of times now since preferred seat came in (or possibly a little after), seat 6 (on 6 max) will be created somewhere nowhere near the window. I've had it appear at the bottom of the screen on occasion. No preferred seat was set though.

Its been ok for me for the last week or so fwiw, and i always saved the changes back to the config when it happened.
sorrow is offline   Reply With Quote
Old 11-06-2008, 07:34 AM   #635
ekdikeo
old hand
 
Join Date: Aug 2006
Posts: 1,308
Re: New Free/open source poker tracking software: FPDB - (Alpha8 - bugfix) - 17-Oct-2

Eleatic: You are able to move the windows around? And you're using Windows?

So this means that somehow the fact that I can't is a bug local to something on my computer. Ugh!


I just pushed a fix to the popups, so they should attach to the window they came from now, and start with the correct color selection (excluding opacity, having a bunch of partially opaque windows on top of each other looks awful)

Last edited by ekdikeo; 11-06-2008 at 08:03 AM.
ekdikeo is offline   Reply With Quote
Old 11-06-2008, 10:36 AM   #636
Eleatic Stranger
journeyman
 
Join Date: Sep 2008
Location: Sydney
Posts: 292
Re: New Free/open source poker tracking software: FPDB - (Alpha8 - bugfix) - 17-Oct-2

Quote:
Originally Posted by ekdikeo View Post
Eleatic: You are able to move the windows around? And you're using Windows?
No: Linux. If you can’t move them this must be Windows-specific.

I haven’t played today so I can’t comment further on the problem, but still feel it is a bit more complex than has been suggested, since it is intermittent. All my tables are the same (I stack them), yet the problem occurs only on some of them and not on others.
Eleatic Stranger is offline   Reply With Quote
Old 11-06-2008, 10:58 AM   #637
Eratosthenes
old hand
 
Join Date: Oct 2004
Posts: 1,535
Re: New Free/open source poker tracking software: FPDB - (Alpha8 - bugfix) - 17-Oct-2

Quote:
Originally Posted by Eleatic Stranger View Post
I haven’t played today so I can’t comment further on the problem, but still feel it is a bit more complex than has been suggested, since it is intermittent. All my tables are the same (I stack them), yet the problem occurs only on some of them and not on others.
I have spent some time staring at the HUD code and don't see why the stat windows are not locating correctly. Do you use the preferred seat feature? Do you think this happens 1% of the time 10%, 50%?? If I don't think of something in the next couple of hours, I will fix up a version with lots of intermediate prints and ask you to run that.

I pushed Eric's fix to the popup just now. So you probably want to get the most recent from my repo.
Eratosthenes is offline   Reply With Quote
Old 11-07-2008, 01:34 AM   #638
Eleatic Stranger
journeyman
 
Join Date: Sep 2008
Location: Sydney
Posts: 292
Re: New Free/open source poker tracking software: FPDB - (Alpha8 - bugfix) - 17-Oct-2

Eratosthenes: I’ve already added code to print out the values being used, and they are all correct; but the problem is still ocurring. I would estimate it happens about 10% of the time, but it is unpredictable. I don’t use and have never used the preferred seat option.

I have now tried the HUD again after adding this function

Code:
    def reposition_windows(self, args):
	for w in self.stat_windows:
            self.stat_windows[w].window.move(self.stat_windows[w].x,
                                             self.stat_windows[w].y)
to the right-click menu of the HUDs, and it puts all the windows back to where they should be – which only adds to the mystery. As you can see, the x and y values are being set correctly, but then the windows, or some of them, are displaced for one reason or another.

I am still of the view that something is going wrong with the thread-locking, since I came across similar graphical artifacts caused by this in the earlier hacked version.

If I can’t crack this myself I will upload a screenshot.

And if you are having trouble re-creating the problem, try sitting down at 20 full-ring play money tables, or failing that 20 full-ring 1c–2c tables, on PS and see if it happens.
Eleatic Stranger is offline   Reply With Quote
Old 11-07-2008, 01:46 AM   #639
sorrow
old hand
 
sorrow's Avatar
 
Join Date: Apr 2008
Location: Perth, Western Australia
Posts: 1,531
Re: New Free/open source poker tracking software: FPDB - (Alpha8 - bugfix) - 17-Oct-2

Quote:
Originally Posted by Eleatic Stranger View Post
I have now tried the HUD again after adding this function
<snip>
to the right-click menu of the HUDs, and it puts all the windows back to where they should be.
Patch please - ekdikeo wants to make the hud windows move with the table when you reposition, this is a good first step.
sorrow is offline   Reply With Quote
Old 11-07-2008, 05:17 AM   #640
Eleatic Stranger
journeyman
 
Join Date: Sep 2008
Location: Sydney
Posts: 292
Re: New Free/open source poker tracking software: FPDB - (Alpha8 - bugfix) - 17-Oct-2

Quote:
Originally Posted by sorrow View Post
Patch please - ekdikeo wants to make the hud windows move with the table when you reposition, this is a good first step.
I’d be delighted; but could you please give me the exact Git command – I am too lazy to look it up.... And are you sure you really want the patch? By rights the function I’ve added shouldn’t do anything at all, and it wouldn’t were this error not occurring.
Eleatic Stranger is offline   Reply With Quote
Old 11-07-2008, 05:25 AM   #641
sorrow
old hand
 
sorrow's Avatar
 
Join Date: Apr 2008
Location: Perth, Western Australia
Posts: 1,531
Re: New Free/open source poker tracking software: FPDB - (Alpha8 - bugfix) - 17-Oct-2

Quote:
Originally Posted by Eleatic Stranger View Post
I’d be delighted; but could you please give me the exact Git command – I am too lazy to look it up.... And are you sure you really want the patch? By rights the function I’ve added shouldn’t do anything at all, and it wouldn’t were this error not occurring.
If you've been using git to pull the updates, then 'git diff' should show any uncommited local mods.

# git diff > patchname.diff

Should do the job.

The patch may not do anything now, but shouldn't take too long to mod to figure out where the new window position is.
sorrow is offline   Reply With Quote
Old 11-07-2008, 12:49 PM   #642
Eratosthenes
old hand
 
Join Date: Oct 2004
Posts: 1,535
Re: New Free/open source poker tracking software: FPDB - (Alpha8 - bugfix) - 17-Oct-2

Quote:
Originally Posted by sorrow View Post
If you've been using git to pull the updates, then 'git diff' should show any uncommited local mods.

# git diff > patchname.diff

Should do the job.

The patch may not do anything now, but shouldn't take too long to mod to figure out where the new window position is.
Don't bother sending a patch. I just copy/pasted from the above and added the appropriate menu item to the popup menu.

I also decided to add an ugly kludge to see if I could avoid the problem. While adding said kludge, I found a pretty subtle typo that might have been the root cause!! So I have added both the fix to the typo and the kludge .

Steffen is putting together a release that will fix the change to the Stars HHs mentioned elsewhere in the Software Forum. That should be available in a few hours and will include these fixes.
Eratosthenes is offline   Reply With Quote
Old 11-07-2008, 01:47 PM   #643
fozzy71
Carpal \'Tunnel
 
fozzy71's Avatar
 
Join Date: Mar 2007
Location: 8 Mile + 2.5
Posts: 37,267
Re: New Free/open source poker tracking software: FPDB - (Alpha8 - bugfix) - 17-Oct-2

Pokerstars real money Badugi games are supposed to be in Monday's update. Where would you like the HHs sent, to try and add Badugi support? Once you have basic Badugi support I will be wanting to download and install your application.
fozzy71 is offline   Reply With Quote
Old 11-09-2008, 02:49 AM   #644
Eleatic Stranger
journeyman
 
Join Date: Sep 2008
Location: Sydney
Posts: 292
Re: New Free/open source poker tracking software: FPDB - (Alpha8 - bugfix) - 17-Oct-2

I’ve noticed something else that is not quite right: when the HUD has been activated the Fpdb process goes into a busy loop and steals all my processor’s idle time, even when there are no hands for it to import. This should be quite easy to correct.
Eleatic Stranger is offline   Reply With Quote
Old 11-09-2008, 09:23 AM   #645
Eratosthenes
old hand
 
Join Date: Oct 2004
Posts: 1,535
Re: New Free/open source poker tracking software: FPDB - (Alpha8 - bugfix) - 17-Oct-2

Quote:
Originally Posted by Eleatic Stranger View Post
I’ve noticed something else that is not quite right: when the HUD has been activated the Fpdb process goes into a busy loop and steals all my processor’s idle time, even when there are no hands for it to import. This should be quite easy to correct.
I think I know what is going on in that. I'll take a look.

You should grab my git repo. It has the window positioning fixes in it. It will be out as an alpha release tomorrow to support the modified Stars hh format.
Eratosthenes is offline   Reply With Quote
Old 11-09-2008, 08:55 PM   #646
steffen123
journeyman
 
Join Date: Aug 2008
Location: Manchester, UK
Posts: 251
Re: New Free/open source poker tracking software: FPDB - (Alpha8 - bugfix) - 17-Oct-2

Hi everyone,
This is alpha9. Many changes have been made, virtually all of them by Ray, Eric and Carl, many of them in the HUD. There's also been quite a lot of work to clean up old code making it more flexible - this will pay off in the future because it makes things more maintainable and flexible. This version also supports PokerStars' new format which is being released on Monday.

Note that default.conf is no longer used, instead all configs are now made in HUD_config.xml (this includes options for fpdb's importer). Re-creating the database is not strictly required this time, but I'm not sure if people fixed potential importer bugs so it might be best to re-import anyways (in the main window select the Database menu and click re-create tables, then bulk import all your files again).

For a detailed changelog please visit the fpdb git tree at assembla.

For any bug reports or problems please visit our help forum at https://****************/forum/forum.php?forum_id=819272

Enjoy!

PS: I didn't have time recently to read this thread, the forums or mailing list, but others have been doing that. I'll catch up this week.
steffen123 is offline   Reply With Quote
Old 11-09-2008, 09:26 PM   #647
Eratosthenes
old hand
 
Join Date: Oct 2004
Posts: 1,535
Re: New Free/open source poker tracking software: FPDB - (Alpha8 - bugfix) - 17-Oct-2

Quote:
Originally Posted by steffen123 View Post
Hi everyone,
This is alpha9. Many changes have been made, virtually all of them by Ray, Eric and Carl, many of them in the HUD. There's also been quite a lot of work to clean up old code making it more flexible - this will pay off in the future because it makes things more maintainable and flexible. This version also supports PokerStars' new format which is being released on Monday.

Note that default.conf is no longer used, instead all configs are now made in HUD_config.xml (this includes options for fpdb's importer). Re-creating the database is not strictly required this time, but I'm not sure if people fixed potential importer bugs so it might be best to re-import anyways (in the main window select the Database menu and click re-create tables, then bulk import all your files again).

For a detailed changelog please visit the fpdb git tree at assembla.

For any bug reports or problems please visit our help forum at https://****************/forum/forum.php?forum_id=819272

Enjoy!

PS: I didn't have time recently to read this thread, the forums or mailing list, but others have been doing that. I'll catch up this week.
Here are a few of the improvements users will probably notice, besides the stars hh update:
  • Good support for stacked/cascaded tables.
  • Misplaced windows noted a few posts back should be fixed.
  • Configuration parameters in default.conf will be moved to HUD_config.xml automatically. After that default.conf will no longer be used.
  • Reasonable defaults will be used for most missing configuration parameters. For example, it should automatically find your Stars and FTP hand history folders.
  • HUD colors are configurable --but you have to edit the xml file .
  • The HUD will appear after the first hand played at the table, instead of the 2nd.
  • Preferred seat support at Stars.
  • Numerous bug fixes.
  • Lots of good infrastructure improvement that are invisible to users for now, but will increase stability and allow more features later.
  • Other things that have slipped my mind.
Eratosthenes is offline   Reply With Quote
Old 11-10-2008, 05:02 AM   #648
Eleatic Stranger
journeyman
 
Join Date: Sep 2008
Location: Sydney
Posts: 292
Re: New Free/open source poker tracking software: FPDB - (Alpha8 - bugfix) - 17-Oct-2

I’ve tried the latest version (the version in the Git repository, which I assume is the same as the version referred to by Steffen) and it works very well. The problem of excess CPU consumption has been resolved; I was going to try dealing with this myself, but there is obviously no need now. The statistics windows are still occasionally being misplaced, however.
Eleatic Stranger is offline   Reply With Quote
Old 11-10-2008, 11:53 AM   #649
steffen123
journeyman
 
Join Date: Aug 2008
Location: Manchester, UK
Posts: 251
Re: New Free/open source poker tracking software: FPDB - (Alpha8 - bugfix) - 17-Oct-2

New users, please see the install instructions on the Wiki, e.g. for Windows: http://fpdb.wiki.****************/Install+in+Windows

I will be updating and wikifying most of the documentation today.
steffen123 is offline   Reply With Quote
Old 11-10-2008, 06:08 PM   #650
Clemenza
centurion
 
Join Date: Mar 2005
Posts: 138
Re: New Free/open source poker tracking software: FPDB - (Alpha8 - bugfix) - 17-Oct-2

There are some good improvements in this new version. Stacked tables and even minimized tables work well and the task bar has been cleaned up. The default.conf parameters moved over to the HUD_config.xml without any problems.

The HUD includes a small window in the top left corner that says "Right click to close HUD for (table name)". This obscures one of the hole cards for seat #8 on 8-max stud, razz and hi/lo tables. Not a huge problem, but just so you know for the next version.

Quote:
Originally Posted by Eratosthenes View Post
HUD colors are configurable --but you have to edit the xml file .
Do you mean the HUD_config.xml in the pyfpdb folder? What lines should I look for to edit?

Thanks again to all the developers!
Clemenza is offline   Reply With Quote

Reply
      

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off


Forum Jump


All times are GMT -4. The time now is 10:12 PM.


Powered by vBulletin®
Copyright ©2000 - 2019, Jelsoft Enterprises Ltd.
Copyright © 2008-2017, Two Plus Two Interactive
 
 
Poker Players - Streaming Live Online