Open Side Menu Go to the Top
Register
Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013 Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013

04-22-2010 , 02:05 AM
Quote:
Originally Posted by Socratic
I checked this against what I believe to be the current git-tree (new at git) and can say this problem with importing pokerstars hands still remains.

Socratic
Before I spend (waste) any more time on trying to get the bulk importer to work with Windows exe latest version 0307, does the bulk importer work or NOT? I read these comments as there being a problem that isn't resolved yet. Can any of the developers say for sure. (regarding PokerStars bulk importer)

edited... I will send you the hh's in question ASAP....

Dog

Last edited by 1meandog4u; 04-22-2010 at 02:10 AM. Reason: Posted simultaneously as you were answering.
Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013 Quote
04-22-2010 , 02:11 AM
Quote:
Originally Posted by 1meandog4u
Before I spend (waste) any more time on trying to get the bulk importer to work with Windows exe latest version 0307, does the bulk importer work or NOT? I read these comments as there being a problem that isn't resolved yet. Can any of the developers say for sure. (regarding PokerStars bulk importer)

Dog
The bulk importer works, but i think we have a regression in certain types of hand histories. I'm able to import 100k of my hands without issue at the moment. I'm only a limited sample though - I play only NLHE + a little bit of PLO.
Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013 Quote
04-22-2010 , 02:22 AM
Quote:
Originally Posted by sorrow
The bulk importer works, but i think we have a regression in certain types of hand histories. I'm able to import 100k of my hands without issue at the moment. I'm only a limited sample though - I play only NLHE + a little bit of PLO.
I just now emailed the two hh's you wanted to see. I have plenty of samples of Omaha hi'lo and limit hold'em

Dog
Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013 Quote
04-22-2010 , 02:27 AM
Quote:
Originally Posted by 1meandog4u
I just now emailed the two hh's you wanted to see. I have plenty of samples of Omaha hi'lo and limit hold'em

Dog
Thanks Dog - that file is definitely failing for me on my system. I should be able to work up a solution pretty quickly.

Sorrow
Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013 Quote
04-22-2010 , 02:39 AM
Quote:
Originally Posted by sorrow
Thanks Dog - that file is definitely failing for me on my system. I should be able to work up a solution pretty quickly.

Sorrow
"Quickly" is always appreciated, but not necessary.

At least I know I'm not totally crazy and the only one having an importer issue.
Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013 Quote
04-22-2010 , 04:06 AM
Quote:
Originally Posted by Socratic
Edited GuiSessionViewer.py as per my own updated instructions ...
Thanks for this; it now works.
Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013 Quote
04-22-2010 , 04:42 AM
Quote:
Originally Posted by 1meandog4u
"Quickly" is always appreciated, but not necessary.

At least I know I'm not totally crazy and the only one having an importer issue.
Nope - you aren't nuts.

I've fixed it in my tree. There was some patches that 'corrected' the lookup for limit blinds, my suspicion is i'll need to fix for all separate blind levels.

Quote:
Originally Posted by Eleatic Stranger
Thanks for this; it now works.
I guess I should take a look at this too
Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013 Quote
04-22-2010 , 07:46 AM
Bear with me - its been a while since i crufted this code...

FWIW - the quick way to crash things at the moment is to only import a single hh file.

Quote:
Originally Posted by Socratic
2.1) The last played session is not included in the candlestick-graph nor the table below it. solution: line 267 of GuiSessionViewer.py should be replaced with:
diffs.append(THRESHOLD + 1) # last hand of last session
This looks wrong.

THRESHOLD is the minimum difference in seconds that we should use to establish sessions - you are literally adding 1801 to the end of the diffs array here.

Giving something like: [0, 10, 20, 15, 1801] - Effectively enforcing that another empty session exists because...
Quote:
Originally Posted by Socratic
# should be marked as an end of session hand to make
# certain the last session gets included by the next
# indexing statement
index = nonzero(diffs > THRESHOLD) # This array represents
# the indexes into 'times' for start/end times of sessions
index = [5]

Quote:
Originally Posted by Socratic
2.2) In the table at the bottom the hands-collumn is of by 1. Solution: line 287 should be replaced with:

hds = index[0][i] - last_idx + 1 # Number of hands in session
That gives you the right result, i'm not sure if its 'correct' though. Looking into it.

Quote:
Originally Posted by Socratic
2.4) The Hands/Hour doesn't display the hands/hour but (an approximation of) minutes in session. Sollution: replace line 291 with

minutesplayed = (times[index[0][i]] - times[last_idx])/60 + 1
# minutes played (approx)
# +1 to make certain it's different from 0 and hence assuming
# the last hand had a duration of 1 minute instead of 0 minutes.
# (I know it's a hack, but it solves possible issues 1 hand-sessions)
# This line should really read something like
# minutesplayed = (EndTimeOfHand(index[0][i]) - times[last_idx])/60
hph = hds*60/minutesplayed # Hands per hour
Heh - hadn't payed attention to that yet.

I went with:
Code:
                minutesplayed = (times[index[0][i]] - times[last_idx])/60 
                if minutesplayed == 0:
                    minutesplayed = 1
                hph = hds*60/minutesplayed # Hands per hour
I've put together something thats working a little better now, but still printing mountains of debug.

I'll clean up and push in a couple of hours.

Sorrow
Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013 Quote
04-22-2010 , 08:21 AM
Quote:
Originally Posted by Socratic
2.2) In the table at the bottom the hands-collumn is of by 1. Solution: line 287 should be replaced with:

hds = index[0][i] - last_idx + 1 # Number of hands in session
Quote:
Originally Posted by sorrow
That gives you the right result, i'm not sure if its 'correct' though. Looking into it.
I've only just noticed this discrepancy. I'll look into it as well to see whether Socratic's patch produces the right results for me. I've ascertained that the total hands played as reported by the graphing function coincides with the actual number reported by the PS client, so this is the true figure the session viewer should be reporting.
Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013 Quote
04-22-2010 , 09:58 AM
hey im trying to get this to work on ubuntu but when i try to run fpdb.py nothing happens.

also when i type in: chmod u+x fpdb.py
i get this: chmod: cannot access `fpdb.py': No such file or directory

anyone know what i should do
Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013 Quote
04-22-2010 , 10:33 AM
Quote:
Originally Posted by bomb diggity
hey im trying to get this to work on ubuntu but when i try to run fpdb.py nothing happens.

also when i type in: chmod u+x fpdb.py
i get this: chmod: cannot access `fpdb.py': No such file or directory

anyone know what i should do
What have you installed? the .deb, git or a .tar.gz version?

Can you copy and paste some output for me?
Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013 Quote
04-22-2010 , 10:58 AM
i installed the git version.

when i try to run fpdb.py in terminal it basically closes instantly but i managed to take a screenshot


im kinda new to linux/ubuntu so i probably screwed something up installing it. should i just start over again?
Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013 Quote
04-22-2010 , 11:50 AM
Quote:
Originally Posted by sorrow
I've put together something thats working a little better now, but still printing mountains of debug.

I'll clean up and push in a couple of hours.

Sorrow
http://trac-git.assembla.com/fpdboz/...6425312d1e3886

The number of hands is still under by 1, which makes me think that the number of hands being used to calculate the stats is missing either the first or last hand. Its happening in the final session too, which makes me think its probably the first hand.
Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013 Quote
04-22-2010 , 02:13 PM
Quote:
Originally Posted by sorrow
This looks wrong.

THRESHOLD is the minimum difference in seconds that we should use to establish sessions - you are literally adding 1801 to the end of the diffs array here.

Giving something like: [0, 10, 20, 15, 1801] - Effectively enforcing that another empty session exists because...


index = [5]
It is right and wrong. Wrong because numpy's ndarray doesn't have a method append. Tx to Eleatic for finding that out.
However the idea is correct. As per my later posting 2.1 should comprise:
Quote:
Originally Posted by Socratic
- replace line 36 with:
Code:
from numpy import diff, nonzero, sum, cumsum, max, min, append
- replace the original line 267 with:
Code:
diffs2 = append(diffs,THRESHOLD + 1)
index = nonzero(diffs2 > THRESHOLD)
Let me explain why my sollution is correct. suppose we have 5 hands with:
Code:
times = [t0=0, t1=t0+600, t2=t1+1900, t3=t2+400, t4=t3+100
In this case we should have 2 sessions: [t0,t1] and [t2,t3,t4].

However the original code will result in:
Code:
diffs = [600,1900,400,100]
index[0] = [1]
meaning that index will result in showing only the session [t0,t1], because range(len(index[0]))=[0].

My updated code will result in:
Code:
diffs = [600,1900,400,100]
diffs2 = [600,1900,400,100,1801]
index[0] = [1,4]
meaning that index will result in showing sessions [t0,t1] and [t2,t3,t4], because range(len(index[0]))=[0,1]

Come to think of it "last_idx" is really a bad name for it's current use. It would be better to name it "first_idx". Because that's what it is: "the index to the first hand of a session."

Quote:
Originally Posted by sorrow
That gives you the right result, i'm not sure if its 'correct' though. Looking into it.
It gives the correct result, because it's correct. That's because how many numbers are between two number, n and m (n<=m), those two numbers included. Answer: m - n + 1. As an example how many number are between 1 and 10, (1 and 10 included). Answer: 10= 10-1 + 1 not 9= 10-1.

Quote:
Originally Posted by sorrow
Heh - hadn't payed attention to that yet.

I went with:
Code:
                minutesplayed = (times[index[0][i]] - times[last_idx])/60 
                if minutesplayed == 0:
                    minutesplayed = 1
                hph = hds*60/minutesplayed # Hands per hour
I've put together something thats working a little better now, but still printing mountains of debug.
That's another option. However, I don't really like it. Why? Because the last hand in the session took some time and you're ignoring it with your code. Come to think of it. Every session takes some additional time before and after actually playing ( before: starting up client, finding first table, sitting down, waiting for BB,...; after: checking stats, checking balance, closing client,... ) So with my code you could imagine even changing my 1 with a constant that signifies the number of minutes spend in the before, after and during final hand for an average session. So adding 1 minute to every session even seems conservative to me ( try starting a session from scratch, playing one hand and closing the session all within 1 minute if you don't believe me. Especially when using auxiliary software like fpdb to get a HUD and to analyse your session afterwords).

To conclude, I've test these changes myself in a git-tree on one of my Linux boxes and hands is not off by one.

I'll stop my rant here.
Socratic.
Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013 Quote
04-22-2010 , 05:01 PM
Quote:
Originally Posted by bomb diggity

when i try to run fpdb.py in terminal it basically closes instantly but i managed to take a screenshot
No need to start again, just looks like the config file isn't found.

Did you setup the config file without any problems ? (Quote from wiki: "Now you need to tell fpdb about the database. Edit 'HUD_config.xml.example' from the pyfpdb directory and save it in the same directory as 'HUD_config.xml' ight(just drop off the .example)-- fpdb will read this in preference to the example config.")

Also, I normally double-click on run_fpdb.py in the parent directory, rather than /pyfpdb/fpdb.py can you try going up one level and using run_fpdb.py instead.

Last edited by gimick; 04-22-2010 at 05:06 PM. Reason: add run_fpdb comment
Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013 Quote
04-22-2010 , 05:53 PM
got it going now, thanks man
Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013 Quote
04-22-2010 , 08:23 PM
ok had it working for like 5 minutes and now im getting this



any ideas
Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013 Quote
04-22-2010 , 08:28 PM
Quote:
Originally Posted by bomb diggity
any ideas
I'm probably the last guy who should make suggestions, but my database on the newest version ends with ".db3" and I noticed yours ends with ".d3b", not sure if that might make a difference.

dog
Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013 Quote
04-22-2010 , 11:01 PM
Quote:
Originally Posted by Socratic
Let me explain why my sollution is correct...
Ahh... lightbulb goes on. Thats a much cleaner solution than what I just posted.
Quote:
Originally Posted by Socratic
Come to think of it "last_idx" is really a bad name for it's current use. It would be better to name it "first_idx". Because that's what it is: "the index to the first hand of a session."
Works for me. I'll update.
Quote:
Originally Posted by Socratic
Answer: m - n + 1
Hindsight is wonderful. I'd convinced myself I wasn't using both the endpoints.
Quote:
Originally Posted by Socratic
That's another option. However, I don't really like it. Why? Because the last hand in the session took some time and you're ignoring it with your code. Come to think of it. Every session takes some additional time before and after actually playing
You've given this a lot more thought than I have.

I think i'm happier with something more precisely defined. Session = time from the start of the first hand to the start of the last hand.

Given that the last hand will often be UTG and folded I don't think this is too unreasonable that we dont add time. Perhaps a 'padding' factor to let user decide.
Quote:
Originally Posted by Socratic
Especially when using auxiliary software like fpdb to get a HUD and to analyse your session afterwords).
Hmm, i like the idea of recording review sessions - length, # of hands loked at, equity calculations... hmm.
Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013 Quote
04-22-2010 , 11:37 PM
Quote:
Originally Posted by bomb diggity
ok had it working for like 5 minutes and now im getting this



any ideas
You are configured to connect to a mysql database called fpdb.db3 - does that database exist?
Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013 Quote
04-23-2010 , 12:27 AM
I hate to keep nagging you guys about this, but any luck on getting the cbet?
Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013 Quote
04-23-2010 , 12:40 AM
Quote:
Originally Posted by arsenal6
I hate to keep nagging you guys about this, but any luck on getting the cbet?
Gimick posted a patch recently with regard to this, highlighting the defference in definition of cbet in fpdb vs everyone else.

I applied his patch to my dev tree about an hour ago but haven't pushed as yet.

Sorrow
Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013 Quote
04-23-2010 , 02:59 AM
Quote:
Originally Posted by sorrow
Gimick posted a patch recently with regard to this, highlighting the defference in definition of cbet in fpdb vs everyone else.

I applied his patch to my dev tree about an hour ago but haven't pushed as yet.

Sorrow
hmm I can't seem to find it? what page is it on?
Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013 Quote
04-23-2010 , 03:59 AM
Quote:
Originally Posted by arsenal6
hmm I can't seem to find it? what page is it on?
Its been on the mailing list - not here.
Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013 Quote
04-23-2010 , 06:02 AM
does this program work with play money or only with real money? and if not could source code be easily modified to work with play money?
Free, open source poker tracking software: FPDB - (Version 0.40.5) - Nov 14, 2013 Quote

      
m