Starting a new workout (been doing it for roughly two weeks) and was looking to get opinions from people way more knowledgeable then me. Workout is every other day. All compound exercises. Been working out for a few years but never consistently. Trying to maximize muscle growth in most efficient way possible.

3-5 minutes warm up (usually jump rope, run)
Dynamic Stretching (5-10 min)
1. (3x 8-12reps) Dead lifts, squats, or lunges.
2.(3x 8-12reps) Dead lifts, squats or lunges.
3. (3x 8-12reps) Flat bar bench, decline, incline or free weights
4. (3x 8-12reps) Row or Lat Pulldown
5. (3x 8-12reps) Military press or shoulder press
6. 1 set each pull-ups, chin-ups, dips (usually 12 reps each)
Core, 1 set each of ab roller 8x, oblique twist with small weight (5-10lbs) 50x, plank 1 minute
static stretching (5 min)

Takes 1hr-1hr 15 min
Generally move up 5-10 lbs after each set. 1st set on any weight can usually do around 12-18 reps max of that weight

The important part is to do something you enjoy and can stick with, and that you consistently add weight to the bar over a long period of time. You're hitting the big exercises, just got to keep at it.

What Aidan said. Different people will have different opinions and can start nitpicking over doing this and not that - including this and definitely not doing that. If you are enjoying what you're doing, keep doing it.

The most important factor like Aidan said is making sure there will be continuous progress over time. Having a program that calls for "3x12, adding 5-10lbs every set" is a good start, but keep in mind that it's physically impossible to keep increasing weights week after week in a linear fashion like that. Once you get stuck it can be easy to suddenly find yourself doing the exact same workouts for months or even years on end without actually making progress anymore.

Progressive overload is key, and will at some point require more advanced programming once you've exhausted your linear gains.