At a glance I thought that shoving flop was just super obvious but after stoving some of your equity vs his likely hands I think you played it fine.
You have such a strong draw that its fine to shove on the flop, its fine to wait till turn and decide, and it's fine to do what you did (getting about 3 to 1express odds and leaving him priced in to call it all on the river for better than 4 to 1 seems OK when you're usually drawing to half the deck).
You don't really know how much equity you have on the flop because you don't know if your over cards are live or not, you also don't know how often he has a hand he can fold to a jam on the flop/turn or if he maybe even has a hand you don't want to fold out OTF (vs. bluff/semi bluff or pocket pair it might be better to see the turn and decide)
Readless, your draw is strong enough that the only clear mistake I can see would be to fold it at any point. (I don't like x/jam turn though because your just not going to fold anything out..may as well either open jam and get some folds or x/c and keep your monies when you miss)
On third thought, you don't know if your opponent has a flush draw, a striaght draw, a set, a TPTKish hand, a combo draw, or maybe an elaborate stunt with air I think I say "here, you do the math" and shove flop