Two Plus Two Publishing LLC Two Plus Two Publishing LLC
 

Go Back   Two Plus Two Poker Forums > Internet Poker > Internet Poker

Notices

Internet Poker Discussions of Internet poker venues.

Reply
 
Thread Tools Display Modes
Old 04-06-2012, 11:38 AM   #1
grinder
 
Join Date: Jan 2007
Posts: 409
Major issue with PS csv Files. PS representative needed.

This issue has occurred since the latest PS update this week.

CSV files are sent by PS comma delimited.
However now ,'s are also being used when a number is over 1k.
This becomes a major issue when trying to view this file in excel or any program that parses the CSV file based on the file being comma delimited.

The example below is of a tournament that was won for 1552.74

In the past this would show as 1552.74 now it shows as 1,552.74

When viewed in any program you will now see 522.74 as the amount of accrued vpp's rather than the amount won because the 1 is left in the amount field and the 522.74 is placed in the accrued vpp's column.

Example of past line
2012/04/05 4:04 PM,Tourn Finished Regular,540009550$2.20 NLHE [Turbo <font color=#00CC66><b>$7.5K Gtd</b></font>], NL Hold'em Buy-In: 2.00/2.000.20 ,USD,1552.74,0.00,0.00,0.00,0.00,2033.25,277.65,5, 896.19,10,100.68,0.00,0.00

Example of line now
2012/04/05 4:04 PM,Tourn Finished Regular,540009550$2.20 NLHE [Turbo <font color=#00CC66><b>$7.5K Gtd</b></font>], NL Hold'em Buy-In: 2.00/2.000.20 ,USD,1,552.74,0.00,0.00,0.00,0.00,2,033.25,277.65, 5,896.19,10,100.68,0.00,0.00
jtflush29 is offline   Reply With Quote
Old 04-06-2012, 11:50 AM   #2
adept
 
paletokio's Avatar
 
Join Date: Nov 2009
Location: Microrollin
Posts: 1,035
Re: Major issue with PS csv Files. PS representative needed.

Does it work if you have a replace all ¨,¨ for nothing?
paletokio is offline   Reply With Quote
Old 04-06-2012, 11:53 AM   #3
grinder
 
Join Date: Jan 2007
Posts: 409
Re: Major issue with PS csv Files. PS representative needed.

Quote:
Originally Posted by paletokio View Post
Does it work if you have a replace all ¨,¨ for nothing?
No then you would just have a string that couldn't be parsed into different columns.

Basic rules of CSV files are a delimiter is chosen then that delimiter is used to separate the columns.
For example if PS wanted to fix this issue they could leave the ,'s for numbers greater than 1k but changer there delimiter to be |.
jtflush29 is offline   Reply With Quote
Old 04-06-2012, 01:38 PM   #4
grinder
 
Join Date: Jan 2007
Posts: 409
Re: Major issue with PS csv Files. PS representative needed.

Response from PS
"
Hello,

While writing the issue up for QA, I found out what the problem is. However, it isn't easily solved until the next server build at minimum.

Here's an edited version of what I sent to our QA, for your information.

-----

This vendor is correct. The attached file below shows a very odd split in winnings for the stated tournament... a split that never happened. (He won cash only). The amount of the Real Money Transfer was also incorrect.

The player was '#######' and the tournament was on March 25, T # 533324091.

I've attached a screenshot of the relevant rows from both the external and internal report. The external (player version) seems to have things in the wrong columns, likely due to comma separation issues.

He won 1457.04 in the event, but it put "1" in the amount column, and 457.04 in the TMoney column because of the comma.

Ditto the balance -- his balance after the event was 2740.86 but the comma split it into 2 and 740.86 in separate columns.

I can't explain the real money transfer at all. It was for $1000, and it separated that into four separate columns of 1 0 0 0. That one wasn't a comma separation issue at all.

As they are now, the player reports are completely unreadable and unusable. These are the reports that players generate in the client, under Requests -> Playing History Audit.

Thanks for reviewing this.

----

As I said, due to software build policy, any fix short of a game-stopping bug is held for deployment at the monthly build cycle, and bugs are fixed on a priority basis. This should be fixed in the May build, but prioritization may bump it back to the June build."
jtflush29 is offline   Reply With Quote
Old 04-06-2012, 02:26 PM   #5
grinder
 
Join Date: Jan 2007
Posts: 409
Re: Major issue with PS csv Files. PS representative needed.

From PS

"No amount of letter writing or petitioning or public outcry will encourage the development team to take down the servers to re-deploy a bug fix for a feature that isn't game-stopping. It simply isn't done.

I cannot promise you a firm date on which this will be fixed, other than to say it will be in a standard scheduled deployment, the next of which is currently slated for early May.

However, if the software team has higher priority bug fixes, it may have to wait for a later build, and builds only happen once a month."
jtflush29 is offline   Reply With Quote
Old 04-06-2012, 02:36 PM   #6
veteran
 
Join Date: Mar 2009
Location: In the wires
Posts: 2,335
Re: Major issue with PS csv Files. PS representative needed.

Somebody should write and post a little script to fix these files.

Just find the regex pattern \d,\d{3}. and remove the comma.

It's important to specify the whole pattern including the period so as to not accidently remove delimiter commas. Looking at the example, all the fields that matter are in currency format.

Last edited by NewOldGuy; 04-06-2012 at 02:43 PM. Reason: simplified expression
NewOldGuy is offline   Reply With Quote
Old 04-06-2012, 02:40 PM   #7
grinder
 
Join Date: Jan 2007
Posts: 409
Re: Major issue with PS csv Files. PS representative needed.

Quote:
Originally Posted by NewOldGuy View Post
Somebody should write and post a little script to fix these files.

Just find the regex pattern [1-9],[1-9][1-9][1-9]. and remove the comma.

It's important to specify the whole pattern including the period so as to not accidently remove delimiter commas. Looking at the example, all the fields that matter are in currency format.
Ya I will probably be doing this for my program.
jtflush29 is offline   Reply With Quote
Old 04-06-2012, 04:02 PM   #8
grinder
 
spilari's Avatar
 
Join Date: Mar 2009
Posts: 600
Re: Major issue with PS csv Files. PS representative needed.

Quote:
Originally Posted by NewOldGuy View Post
Somebody should write and post a little script to fix these files.

Just find the regex pattern \d,\d{3}. and remove the comma.

It's important to specify the whole pattern including the period so as to not accidently remove delimiter commas. Looking at the example, all the fields that matter are in currency format.
this is not guaranteed to work.
in the example lines supplied by OP, there are some columns without decimals that would break by this regex for some values.

but yes, should be possible to write a script for this.
spilari is offline   Reply With Quote
Old 04-06-2012, 04:05 PM   #9
grinder
 
Join Date: Jan 2007
Posts: 409
Re: Major issue with PS csv Files. PS representative needed.

Quote:
Originally Posted by spilari View Post
this is not guaranteed to work.
in the example lines supplied by OP, there are some columns without decimals that would break by this regex for some values.

but yes, should be possible to write a script for this.
Ya I am not using what was suggested. I am currently working on the fix and should have a new release of Tournament Parser today.
jtflush29 is offline   Reply With Quote
Old 04-06-2012, 06:15 PM   #10
grinder
 
Join Date: Jan 2007
Posts: 409
Re: Major issue with PS csv Files. PS representative needed.

Version 2.94 is now available at http://www.tournamentparser.com
Fix added for PokerStars Audit file change which affected winnings 1k and over.

You can read details about the PS audit issue below.
http://forumserver.twoplustwo.com/28.../#post32464793
http://forum.parttimepoker.com/shoot...-may-june.html
jtflush29 is offline   Reply With Quote
Old 04-06-2012, 07:43 PM   #11
Pooh-Bah
 
Join Date: Jun 2009
Posts: 5,862
Re: Major issue with PS csv Files. PS representative needed.

I guess this proves PS only has one programmer.. otherwise the other guy would have noticed it on code review
Kittens is offline   Reply With Quote
Old 04-06-2012, 07:45 PM   #12
grinder
 
Join Date: Jan 2007
Posts: 409
Re: Major issue with PS csv Files. PS representative needed.

Quote:
Originally Posted by Kittens View Post
I guess this proves PS only has one programmer.. otherwise the other guy would have noticed it on code review


Tournament Parser has one programmer. When something breaks I fix it.
I don't say it will be fixed in 2 months
jtflush29 is offline   Reply With Quote

Reply
      

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are Off
Pingbacks are Off
Refbacks are Off



All times are GMT -4. The time now is 09:22 PM.


Powered by vBulletin®
Copyright ©2000 - 2013, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO 3.6.0 ©2011, Crawlability, Inc.
Copyright © 2008-2010, Two Plus Two Interactive